ScopedProcessInformation protects against process/thread handle leaks from CreateProcess calls.

chrome/installer/util/move_tree_work_item_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 
 #include <fstream>
 
 #include "base/base_paths.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/string_util.h"
+#include "base/win/scoped_process_information.h"
 #include "chrome/installer/util/work_item.h"
 #include "chrome/installer/util/move_tree_work_item.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 class MoveTreeWorkItemTest : public testing::Test {
  protected:
   virtual void SetUp() {
     ASSERT_TRUE(temp_from_dir_.CreateUniqueTempDir());
     ASSERT_TRUE(temp_to_dir_.CreateUniqueTempDir());
@@ skipping 248 matching lines @@
   wchar_t exe_full_path_str[MAX_PATH];
   ::GetModuleFileName(NULL, exe_full_path_str, MAX_PATH);
   FilePath exe_full_path(exe_full_path_str);
   FilePath to_file(to_dir);
   to_file = to_file.AppendASCII("To_File");
   file_util::CopyFile(exe_full_path, to_file);
   ASSERT_TRUE(file_util::PathExists(to_file));
 
   // Run the executable in destination path
   STARTUPINFOW si = {sizeof(si)};
-  PROCESS_INFORMATION pi = {0};
+  base::win::ScopedProcessInformation pi;
   ASSERT_TRUE(::CreateProcess(NULL,
                               const_cast<wchar_t*>(to_file.value().c_str()),
                               NULL, NULL, FALSE,
                               CREATE_NO_WINDOW | CREATE_SUSPENDED,
-                              NULL, NULL, &si, &pi));
+                              NULL, NULL, &si, pi.Receive()));
 
   // test Do()
   scoped_ptr<MoveTreeWorkItem> work_item(
       WorkItem::CreateMoveTreeWorkItem(from_file,
                                        to_file,
                                        temp_to_dir_.path(),
                                        WorkItem::ALWAYS_MOVE));
   EXPECT_TRUE(work_item->Do());
 
   EXPECT_TRUE(file_util::PathExists(from_dir));
   EXPECT_FALSE(file_util::PathExists(from_file));
   EXPECT_TRUE(file_util::PathExists(to_dir));
   EXPECT_EQ(0, ReadTextFile(to_file).compare(kTextContent1));
 
   // test rollback()
   work_item->Rollback();
 
   EXPECT_TRUE(file_util::PathExists(from_dir));
   EXPECT_EQ(0, ReadTextFile(from_file).compare(kTextContent1));
   EXPECT_TRUE(file_util::PathExists(to_dir));
   EXPECT_TRUE(file_util::ContentsEqual(exe_full_path, to_file));
 
-  TerminateProcess(pi.hProcess, 0);
-  EXPECT_TRUE(WaitForSingleObject(pi.hProcess, 10000) == WAIT_OBJECT_0);
-  CloseHandle(pi.hProcess);
-  CloseHandle(pi.hThread);
+  TerminateProcess(pi.Get().hProcess, 0);
+  EXPECT_TRUE(WaitForSingleObject(pi.Get().hProcess, 10000) == WAIT_OBJECT_0);
 }
 
 // Move one file that is in use to destination.
 TEST_F(MoveTreeWorkItemTest, MoveFileInUse) {
   // Create an executable for source by copying ourself to a new source dir.
   FilePath from_dir(temp_from_dir_.path());
   from_dir = from_dir.AppendASCII("From_Dir");
   file_util::CreateDirectory(from_dir);
   ASSERT_TRUE(file_util::PathExists(from_dir));
 
@@ skipping 11 matching lines @@
   file_util::CreateDirectory(to_dir);
   ASSERT_TRUE(file_util::PathExists(to_dir));
 
   FilePath to_file(to_dir);
   to_file = to_file.AppendASCII("To_File");
   CreateTextFile(to_file.value(), kTextContent1);
   ASSERT_TRUE(file_util::PathExists(to_file));
 
   // Run the executable in source path
   STARTUPINFOW si = {sizeof(si)};
-  PROCESS_INFORMATION pi = {0};
+  base::win::ScopedProcessInformation pi;
   ASSERT_TRUE(::CreateProcess(NULL,
                               const_cast<wchar_t*>(from_file.value().c_str()),
                               NULL, NULL, FALSE,
                               CREATE_NO_WINDOW | CREATE_SUSPENDED,
-                              NULL, NULL, &si, &pi));
+                              NULL, NULL, &si, pi.Receive()));
 
   // test Do()
   scoped_ptr<MoveTreeWorkItem> work_item(
       WorkItem::CreateMoveTreeWorkItem(from_file,
                                        to_file,
                                        temp_to_dir_.path(),
                                        WorkItem::ALWAYS_MOVE));
   EXPECT_TRUE(work_item->Do());
 
   EXPECT_TRUE(file_util::PathExists(from_dir));
   EXPECT_FALSE(file_util::PathExists(from_file));
   EXPECT_TRUE(file_util::PathExists(to_dir));
   EXPECT_TRUE(file_util::ContentsEqual(exe_full_path, to_file));
 
   // Close the process and make sure all the conditions after Do() are
   // still true.
-  TerminateProcess(pi.hProcess, 0);
-  EXPECT_TRUE(WaitForSingleObject(pi.hProcess, 10000) == WAIT_OBJECT_0);
-  CloseHandle(pi.hProcess);
-  CloseHandle(pi.hThread);
+  TerminateProcess(pi.Get().hProcess, 0);
+  EXPECT_TRUE(WaitForSingleObject(pi.Get().hProcess, 10000) == WAIT_OBJECT_0);
 
   EXPECT_TRUE(file_util::PathExists(from_dir));
   EXPECT_FALSE(file_util::PathExists(from_file));
   EXPECT_TRUE(file_util::PathExists(to_dir));
   EXPECT_TRUE(file_util::ContentsEqual(exe_full_path, to_file));
 
   // test rollback()
   work_item->Rollback();
 
   EXPECT_TRUE(file_util::PathExists(from_dir));
@@ skipping 161 matching lines @@
   // the source files.
   EXPECT_TRUE(file_util::PathExists(from_dir1));
   EXPECT_TRUE(file_util::PathExists(to_dir));
   EXPECT_TRUE(file_util::PathExists(orig_to_file));
   EXPECT_EQ(0, ReadTextFile(orig_to_file).compare(kTextContent1));
   EXPECT_EQ(0, ReadTextFile(from_file).compare(kTextContent1));
 
   // Also, after rollback the new "to" file should be gone.
   EXPECT_FALSE(file_util::PathExists(new_to_file2));
 }