ScopedProcessInformation protects against process/thread handle leaks from CreateProcess calls.

chrome/installer/util/copy_tree_work_item_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 
 #include <fstream>
 
 #include "base/base_paths.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/scoped_temp_dir.h"
 #include "base/string_util.h"
 #include "base/threading/platform_thread.h"
+#include "base/win/scoped_process_information.h"
 #include "chrome/installer/util/copy_tree_work_item.h"
 #include "chrome/installer/util/work_item.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
   class CopyTreeWorkItemTest : public testing::Test {
    protected:
     virtual void SetUp() {
       ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
       ASSERT_TRUE(test_dir_.CreateUniqueTempDir());
@@ skipping 310 matching lines @@
   FilePath file_name_to(dir_name_to);
   file_name_to = file_name_to.AppendASCII("File_To");
   file_util::CopyFile(exe_full_path, file_name_to);
   ASSERT_TRUE(file_util::PathExists(file_name_to));
 
   VLOG(1) << "copy ourself from " << exe_full_path.value()
           << " to " << file_name_to.value();
 
   // Run the executable in destination path
   STARTUPINFOW si = {sizeof(si)};
-  PROCESS_INFORMATION pi = {0};
+  base::win::ScopedProcessInformation pi;
   ASSERT_TRUE(
       ::CreateProcess(NULL, const_cast<wchar_t*>(file_name_to.value().c_str()),
-                       NULL, NULL, FALSE, CREATE_NO_WINDOW | CREATE_SUSPENDED,
-                       NULL, NULL, &si, &pi));
+                      NULL, NULL, FALSE, CREATE_NO_WINDOW | CREATE_SUSPENDED,
+                      NULL, NULL, &si, pi.Receive()));
 
   // test Do().
   scoped_ptr<CopyTreeWorkItem> work_item(
       WorkItem::CreateCopyTreeWorkItem(file_name_from,
                                        file_name_to,
                                        temp_dir_.path(),
                                        WorkItem::IF_DIFFERENT,
                                        FilePath()));
 
   EXPECT_TRUE(work_item->Do());
@@ skipping 14 matching lines @@
   // test rollback()
   work_item->Rollback();
 
   EXPECT_TRUE(file_util::PathExists(file_name_from));
   EXPECT_TRUE(file_util::PathExists(file_name_to));
   EXPECT_EQ(0, ReadTextFile(file_name_from.value()).compare(text_content_1));
   EXPECT_TRUE(file_util::ContentsEqual(exe_full_path, file_name_to));
   // the backup file should be gone after rollback
   EXPECT_FALSE(file_util::PathExists(backup_file));
 
-  TerminateProcess(pi.hProcess, 0);
-  // make sure the handle is closed.
-  EXPECT_TRUE(WaitForSingleObject(pi.hProcess, 10000) == WAIT_OBJECT_0);
-  CloseHandle(pi.hProcess);
-  CloseHandle(pi.hThread);
+  TerminateProcess(pi.Get().hProcess, 0);
+  EXPECT_TRUE(WaitForSingleObject(pi.Get().hProcess, 10000) == WAIT_OBJECT_0);
 }
 
 // Test overwrite option NEW_NAME_IF_IN_USE:
 // 1. If destination file is in use, the source should be copied with the
 //    new name after Do() and this new name file should be deleted
 //    after rollback.
 // 2. If destination file is not in use, the source should be copied in the
 //    destination folder after Do() and should be rolled back after Rollback().
 TEST_F(CopyTreeWorkItemTest, NewNameAndCopyTest) {
   // Create source file
@@ skipping 16 matching lines @@
   file_name_to = file_name_to.AppendASCII("File_To");
   alternate_to = alternate_to.AppendASCII("Alternate_To");
   file_util::CopyFile(exe_full_path, file_name_to);
   ASSERT_TRUE(file_util::PathExists(file_name_to));
 
   VLOG(1) << "copy ourself from " << exe_full_path.value()
           << " to " << file_name_to.value();
 
   // Run the executable in destination path
   STARTUPINFOW si = {sizeof(si)};
-  PROCESS_INFORMATION pi = {0};
+  base::win::ScopedProcessInformation pi;
   ASSERT_TRUE(
       ::CreateProcess(NULL, const_cast<wchar_t*>(file_name_to.value().c_str()),
-                       NULL, NULL, FALSE, CREATE_NO_WINDOW | CREATE_SUSPENDED,
-                       NULL, NULL, &si, &pi));
+                      NULL, NULL, FALSE, CREATE_NO_WINDOW | CREATE_SUSPENDED,
+                      NULL, NULL, &si, pi.Receive()));
 
   // test Do().
   scoped_ptr<CopyTreeWorkItem> work_item(
       WorkItem::CreateCopyTreeWorkItem(file_name_from,
                                        file_name_to,
                                        temp_dir_.path(),
                                        WorkItem::NEW_NAME_IF_IN_USE,
                                        alternate_to));
 
   EXPECT_TRUE(work_item->Do());
@@ skipping 10 matching lines @@
   work_item->Rollback();
 
   EXPECT_TRUE(file_util::PathExists(file_name_from));
   EXPECT_TRUE(file_util::PathExists(file_name_to));
   EXPECT_EQ(0, ReadTextFile(file_name_from.value()).compare(text_content_1));
   EXPECT_TRUE(file_util::ContentsEqual(exe_full_path, file_name_to));
   EXPECT_TRUE(work_item->backup_path_.path().empty());
   // the alternate file should be gone after rollback
   EXPECT_FALSE(file_util::PathExists(alternate_to));
 
-  TerminateProcess(pi.hProcess, 0);
-  // make sure the handle is closed.
-  EXPECT_TRUE(WaitForSingleObject(pi.hProcess, 10000) == WAIT_OBJECT_0);
-  CloseHandle(pi.hProcess);
-  CloseHandle(pi.hThread);
+  TerminateProcess(pi.Get().hProcess, 0);
+  EXPECT_TRUE(WaitForSingleObject(pi.Get().hProcess, 10000) == WAIT_OBJECT_0);
 
   // Now the process has terminated, lets try overwriting the file again
   work_item.reset(WorkItem::CreateCopyTreeWorkItem(
       file_name_from, file_name_to,
       temp_dir_.path(), WorkItem::NEW_NAME_IF_IN_USE,
       alternate_to));
   if (IsFileInUse(file_name_to))
     base::PlatformThread::Sleep(2000);
   // If file is still in use, the rest of the test will fail.
   ASSERT_FALSE(IsFileInUse(file_name_to));
@@ skipping 132 matching lines @@
   FilePath file_name_to(dir_name_to);
   file_name_to = file_name_to.AppendASCII("File_To");
   file_util::CopyFile(exe_full_path, file_name_to);
   ASSERT_TRUE(file_util::PathExists(file_name_to));
 
   VLOG(1) << "copy ourself from " << exe_full_path.value()
           << " to " << file_name_to.value();
 
   // Run the executable in destination path
   STARTUPINFOW si = {sizeof(si)};
-  PROCESS_INFORMATION pi = {0};
+  base::win::ScopedProcessInformation pi;
   ASSERT_TRUE(
       ::CreateProcess(NULL, const_cast<wchar_t*>(file_name_to.value().c_str()),
-                       NULL, NULL, FALSE, CREATE_NO_WINDOW | CREATE_SUSPENDED,
-                       NULL, NULL, &si, &pi));
+                      NULL, NULL, FALSE, CREATE_NO_WINDOW | CREATE_SUSPENDED,
+                      NULL, NULL, &si, pi.Receive()));
 
   FilePath backup_file;
 
   // test Do().
   {
     scoped_ptr<CopyTreeWorkItem> work_item(
         WorkItem::CreateCopyTreeWorkItem(file_name_from,
                                          file_name_to,
                                          temp_dir_.path(),
                                          WorkItem::IF_DIFFERENT,
@@ skipping 12 matching lines @@
     EXPECT_EQ(0, ReadTextFile(file_name_to.value()).compare(text_content_1));
     // verify the file in used is moved to backup place.
     EXPECT_TRUE(file_util::PathExists(backup_file));
     EXPECT_TRUE(file_util::ContentsEqual(exe_full_path, backup_file));
   }
 
   // verify the file in used should be still at the backup place.
   EXPECT_TRUE(file_util::PathExists(backup_file));
   EXPECT_TRUE(file_util::ContentsEqual(exe_full_path, backup_file));
 
-  TerminateProcess(pi.hProcess, 0);
-  // make sure the handle is closed.
-  EXPECT_TRUE(WaitForSingleObject(pi.hProcess, 10000) == WAIT_OBJECT_0);
-  CloseHandle(pi.hProcess);
-  CloseHandle(pi.hThread);
+  TerminateProcess(pi.Get().hProcess, 0);
+  EXPECT_TRUE(WaitForSingleObject(pi.Get().hProcess, 10000) == WAIT_OBJECT_0);
 }
 
 // Copy a tree from source to destination.
 // Flaky, http://crbug.com/59784.
 TEST_F(CopyTreeWorkItemTest, DISABLED_CopyTree) {
   // Create source tree
   FilePath dir_name_from(test_dir_.path());
   dir_name_from = dir_name_from.AppendASCII("from");
   file_util::CreateDirectory(dir_name_from);
   ASSERT_TRUE(file_util::PathExists(dir_name_from));
@@ skipping 42 matching lines @@
   EXPECT_TRUE(file_util::ContentsEqual(file_name_from_1, file_name_to_1));
 
   FilePath file_name_to_2(dir_name_to);
   file_name_to_2 = file_name_to_2.AppendASCII("2");
   file_name_to_2 = file_name_to_2.AppendASCII("File_2.txt");
   EXPECT_TRUE(file_util::PathExists(file_name_to_2));
   VLOG(1) << "compare " << file_name_from_2.value()
           << " and " << file_name_to_2.value();
   EXPECT_TRUE(file_util::ContentsEqual(file_name_from_2, file_name_to_2));
 }