Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 9700028: Add a private PPB_Talk_Private interface. (Closed)

Created:
8 years, 9 months ago by varunjain
Modified:
8 years, 9 months ago
Reviewers:
brettw, jam
CC:
chromium-reviews, piman+watch_chromium.org, ihf+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add a private PPB_Talk_Private interface. It exposes one function that sends a message to the browser and issues a reply. The browser doesn't implement this yet. BUG=117564 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127564

Patch Set 1 #

Patch Set 2 : patch #

Patch Set 3 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -0 lines) Patch
M content/ppapi_plugin/ppapi_thread.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A ppapi/api/private/ppb_talk_private.idl View 1 chunk +35 lines, -0 lines 0 comments Download
A ppapi/c/private/ppb_talk_private.h View 1 chunk +58 lines, -0 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_talk_private_proxy.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_talk_private_proxy.cc View 1 2 1 chunk +92 lines, -0 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/shared_impl/api_id.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/resource.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_talk_private_api.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_talk_private_thunk.cc View 1 1 chunk +43 lines, -0 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
varunjain
8 years, 9 months ago (2012-03-14 18:16:26 UTC) #1
jam
see my comment in https://chromiumcodereview.appspot.com/9683003/. this can be simplified if you just send a sync ...
8 years, 9 months ago (2012-03-15 02:06:32 UTC) #2
varunjain
On 2012/03/15 02:06:32, John Abd-El-Malek wrote: > see my comment in https://chromiumcodereview.appspot.com/9683003/. this can be ...
8 years, 9 months ago (2012-03-15 17:41:08 UTC) #3
varunjain
On 2012/03/15 17:41:08, varunjain wrote: > On 2012/03/15 02:06:32, John Abd-El-Malek wrote: > > see ...
8 years, 9 months ago (2012-03-15 17:50:34 UTC) #4
varunjain
Brett, I have changed this patch so that the plugin side proxy now sends a ...
8 years, 9 months ago (2012-03-19 09:07:21 UTC) #5
brettw
lgtm
8 years, 9 months ago (2012-03-19 17:46:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/9700028/8001
8 years, 9 months ago (2012-03-19 18:43:47 UTC) #7
commit-bot: I haz the power
Try job failure for 9700028-8001 (retry) on mac_rel for step "browser_tests" (clobber build). It's a ...
8 years, 9 months ago (2012-03-19 20:17:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/9700028/8001
8 years, 9 months ago (2012-03-19 20:36:15 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-19 23:00:32 UTC) #10
Try job failure for 9700028-8001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "browser_tests, installer_util_unittests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698