media/base/pipeline.h - Issue 9700006: Move VideoDecoder out of media pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/pipeline.h

Issue 9700006: Move VideoDecoder out of media pipeline. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revised on fischman's comments. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/pipeline.h

diff --git a/media/base/pipeline.h b/media/base/pipeline.h

index c960912075f94b4254ed941f229e623fbbd5afca..9dfbfd65c616be07ec6e10e26919783d03ab21b9 100644

--- a/media/base/pipeline.h

+++ b/media/base/pipeline.h

@@ -603,7 +603,9 @@ class MEDIA_EXPORT Pipeline

// Decoder reference used for signalling imminent shutdown.

// This is a HACK necessary because WebMediaPlayerImpl::Destroy() holds the

// renderer thread loop hostage for until PipelineImpl::Stop() calls its

- // callback. http://crbug.com/110228 tracks removing this hack.

+ // callback.

+ // This reference should only be used for this hack and no other purposes.

+ // http://crbug.com/110228 tracks removing this hack.

scoped_refptr<VideoDecoder> video_decoder_;

// Renderer references used for setting the volume and determining