Move VideoDecoder out of media pipeline.

media/base/filters.h

Index: media/base/filters.h
diff --git a/media/base/filters.h b/media/base/filters.h
index 50dc686383d67729246b62e3f66bf9f54f7be1d6..d41a237b3450c7ca86445ba4e106877bec1aae56 100644
--- a/media/base/filters.h
+++ b/media/base/filters.h
@@ -175,10 +175,10 @@ class MEDIA_EXPORT VideoRenderer : public Filter {
 
   // Initialize a VideoRenderer with the given VideoDecoder, executing the
   // callback upon completion.
-  virtual void Initialize(VideoDecoder* decoder,
-                          const PipelineStatusCB& callback,
+  virtual void Initialize(const scoped_refptr<VideoDecoder>& decoder,
+                          const PipelineStatusCB& pipeline_status_cb,

[Ami GONE FROM CHROMIUM, 2012/03/14 20:05:01]

s/pipeline_// ?

[xhwang, 2012/03/14 22:28:41]

I chose this verbose name because status_cb and stats_cb (once used in various
places) were too similar. Now since we use statistics_cb for the latter, this
doesn't matter any more. Anything bad except it's too long? :)

[Ami GONE FROM CHROMIUM, 2012/03/14 22:42:50]

My only objection is the length.

[xhwang, 2012/03/14 22:59:42]

Okay, will change this in the next CL too.

                           const StatisticsCB& statistics_cb,
-                          const VideoTimeCB& time_cb) = 0;
+                          const VideoTimeCB& video_time_cb) = 0;

[Ami GONE FROM CHROMIUM, 2012/03/14 20:05:01]

IMO "Video" belongs in neither the param name nor the type name (look at the
typedef; there's nothing video-specific about it).

[xhwang, 2012/03/14 22:28:41]

Will do in another CL.

 
   // Returns true if this filter has received and processed an end-of-stream
   // buffer.