Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: chrome/browser/ui/cocoa/browser_frame_view.mm

Issue 9700002: [Mac] Use NSThemeFrame instead of NSGrayFrame on 10.8. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_frame_view.mm
diff --git a/chrome/browser/ui/cocoa/browser_frame_view.mm b/chrome/browser/ui/cocoa/browser_frame_view.mm
index 41d78385354df3ae072b4cda6980950d584a6c19..f6e8c89b76e84113d508f56b5f5a452ebcf2c7a4 100644
--- a/chrome/browser/ui/cocoa/browser_frame_view.mm
+++ b/chrome/browser/ui/cocoa/browser_frame_view.mm
@@ -8,6 +8,7 @@
#import <Carbon/Carbon.h>
#include "base/logging.h"
+#include "base/mac/mac_util.h"
#include "base/mac/scoped_nsautorelease_pool.h"
#import "chrome/browser/themes/theme_service.h"
#import "chrome/browser/ui/cocoa/framed_browser_window.h"
@@ -46,7 +47,11 @@ static BOOL gCanGetCornerRadius = NO;
// roll overs for our close widgets, but things should still function
// correctly.
base::mac::ScopedNSAutoreleasePool pool;
- Class grayFrameClass = NSClassFromString(@"NSGrayFrame");
+
+ // On 10.8+ textured windows are no longer drawn by NSGrayFrame, and
Avi (use Gerrit) 2012/03/14 02:17:50 I didn't know that we were using textured windows.
Robert Sesek 2012/03/14 15:00:29 Done. Textured windows are the easiest way to not
+ // NSThemeFrame is used instead <http://crbug.com/114745>.
+ Class grayFrameClass = NSClassFromString(
Avi (use Gerrit) 2012/03/14 02:17:50 variable rename?
Robert Sesek 2012/03/14 15:00:29 Done.
+ base::mac::IsOSMountainLionOrLater() ? @"NSThemeFrame" : @"NSGrayFrame");
DCHECK(grayFrameClass);
if (!grayFrameClass) return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698