Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9700002: [Mac] Use NSThemeFrame instead of NSGrayFrame on 10.8. (Closed)

Created:
8 years, 9 months ago by Robert Sesek
Modified:
8 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Use NSThemeFrame instead of NSGrayFrame on 10.8. BUG=114745 TEST=Theming works on 10.8. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126787

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M chrome/browser/ui/cocoa/browser_frame_view.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_frame_view.mm View 1 3 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Robert Sesek
8 years, 9 months ago (2012-03-14 00:21:56 UTC) #1
Avi (use Gerrit)
lgtm http://codereview.chromium.org/9700002/diff/1/chrome/browser/ui/cocoa/browser_frame_view.mm File chrome/browser/ui/cocoa/browser_frame_view.mm (right): http://codereview.chromium.org/9700002/diff/1/chrome/browser/ui/cocoa/browser_frame_view.mm#newcode51 chrome/browser/ui/cocoa/browser_frame_view.mm:51: // On 10.8+ textured windows are no longer ...
8 years, 9 months ago (2012-03-14 02:17:50 UTC) #2
Robert Sesek
http://codereview.chromium.org/9700002/diff/1/chrome/browser/ui/cocoa/browser_frame_view.mm File chrome/browser/ui/cocoa/browser_frame_view.mm (right): http://codereview.chromium.org/9700002/diff/1/chrome/browser/ui/cocoa/browser_frame_view.mm#newcode51 chrome/browser/ui/cocoa/browser_frame_view.mm:51: // On 10.8+ textured windows are no longer drawn ...
8 years, 9 months ago (2012-03-14 15:00:29 UTC) #3
Avi (use Gerrit)
SLGTM
8 years, 9 months ago (2012-03-14 15:17:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9700002/4001
8 years, 9 months ago (2012-03-14 21:32:36 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 23:23:22 UTC) #6 
Change committed as 126787

Powered by Google App Engine
This is Rietveld 408576698