Move *keychain_mac* files to crypto/

crypto/mock_keychain_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "base/time.h"
-#include "chrome/browser/mock_keychain_mac.h"
+#include "crypto/mock_keychain_mac.h"
+
+namespace crypto {
 
 MockKeychain::MockKeychain()
     : next_item_key_(0),
       search_copy_count_(0),
       keychain_item_copy_count_(0),
       attribute_data_copy_count_(0),
       find_generic_result_(noErr),
       called_add_generic_(false),
       password_data_count_(0) {}
 
@@ skipping 37 matching lines @@
       keychain_attr_list_[key].attr[i].length = data_size;
       keychain_attr_list_[key].attr[i].data = calloc(1, data_size);
     }
   }
 }
 
 MockKeychain::~MockKeychain() {
   for (std::map<unsigned int, SecKeychainAttributeList>::iterator it =
        keychain_attr_list_.begin(); it != keychain_attr_list_.end(); ++it) {
     for (unsigned int i = 0; i < it->second.count; ++i) {
       if (it->second.attr[i].data) {

[Ryan Sleevi, 2012/03/16 20:58:37]

nit: Per http://www.chromium.org/developers/coding-style#TOC-Code-formatting 

Other formatting "rules" are not required, but are fairly common across Chrome
code, and thus it's probably best to stick to them unless you have a reason not
to.  In particular, if existing code follows these styles, maintain them:
Prefer (foo == 0) to (0 == foo)
Omit {} for one-line conditional or loop bodies
Function declaration order should match function definition order

wtc tends to ding me on these, so it should be true in crypto/ land that this is
fairly consistent. I haven't done an audit, but something to consider.

[akalin, 2012/03/17 07:19:44]

I made a pass to clean up simple if statements and indentation.  I didn't want
to go further than that, though, as this class is pretty complex and has no unit
tests, and reordering functions would make it hard to see the diffs.

         free(it->second.attr[i].data);
       }
     }
     free(it->second.attr);
     if (keychain_data_[it->first].data) {
       free(keychain_data_[it->first].data);
     }
   }
   keychain_attr_list_.clear();
   keychain_data_.clear();
@@ skipping 440 matching lines @@
   SetTestDataProtocol(key, item_data.protocol);
   SetTestDataString(key, kSecPathItemAttr, item_data.path);
   SetTestDataPort(key, item_data.port);
   SetTestDataString(key, kSecSecurityDomainItemAttr,
                     item_data.security_domain);
   SetTestDataString(key, kSecCreationDateItemAttr, item_data.creation_date);
   SetTestDataString(key, kSecAccountItemAttr, item_data.username);
   SetTestDataPasswordString(key, item_data.password);
   SetTestDataNegativeItem(key, item_data.negative_item);
 }
+
+} // namespace crypto