Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9699106: Check explicitly for PPB_MouseLock v1.0 in pp::MouseLock. (Closed)

Created:
8 years, 9 months ago by Wez
Modified:
8 years, 9 months ago
Reviewers:
yzshen1
CC:
chromium-reviews
Visibility:
Public.

Description

Check explicitly for PPB_MouseLock v1.0 in pp::MouseLock. BUG=107398 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127356

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ppapi/cpp/mouse_lock.cc View 2 chunks +6 lines, -6 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
Wez
8 years, 9 months ago (2012-03-16 05:45:49 UTC) #1
yzshen1
http://codereview.chromium.org/9699106/diff/1/ppapi/cpp/mouse_lock.cc File ppapi/cpp/mouse_lock.cc (right): http://codereview.chromium.org/9699106/diff/1/ppapi/cpp/mouse_lock.cc#newcode19 ppapi/cpp/mouse_lock.cc:19: static const char kPPPMouseLockInterface[] = PPP_MOUSELOCK_INTERFACE; Shall we do ...
8 years, 9 months ago (2012-03-16 06:18:55 UTC) #2
Wez
On 2012/03/16 06:18:55, yzshen1 wrote: > http://codereview.chromium.org/9699106/diff/1/ppapi/cpp/mouse_lock.cc > File ppapi/cpp/mouse_lock.cc (right): > > http://codereview.chromium.org/9699106/diff/1/ppapi/cpp/mouse_lock.cc#newcode19 > ...
8 years, 9 months ago (2012-03-16 19:52:37 UTC) #3
yzshen1
lgtm
8 years, 9 months ago (2012-03-16 19:57:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9699106/1
8 years, 9 months ago (2012-03-16 20:06:08 UTC) #5
commit-bot: I haz the power
Try job failure for 9699106-1 (retry) (retry) on mac_rel for steps "ui_tests, browser_tests" (clobber build). ...
8 years, 9 months ago (2012-03-16 22:24:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9699106/1
8 years, 9 months ago (2012-03-16 23:36:35 UTC) #7
commit-bot: I haz the power
Try job failure for 9699106-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-17 00:31:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9699106/1
8 years, 9 months ago (2012-03-17 07:00:54 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-17 12:14:30 UTC) #10 
Change committed as 127356

Powered by Google App Engine
This is Rietveld 408576698