Add functionality to pppapi TCPSocket to support secure sockets in flash

ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h"
 
 #include "base/logging.h"
 #include "ppapi/shared_impl/ppapi_globals.h"
 #include "ppapi/shared_impl/var.h"
 #include "ppapi/shared_impl/var_tracker.h"
 
 namespace ppapi {
 
+PPB_X509Certificate_Fields::PPB_X509Certificate_Fields() {

[Ryan Sleevi, 2012/04/06 00:37:49]

nit: Same line for empty ctors when they fit.

[raymes, 2012/04/06 23:22:47]

Done.

+}
+
+PPB_X509Certificate_Fields::PPB_X509Certificate_Fields(
+    const PPB_X509Certificate_Fields& fields) {
+  for (size_t i = 0; i < fields.values_.GetSize(); ++i) {

[yzshen1, 2012/04/06 19:24:33]

[nit, optional] Can you use
virtual ListValue* DeepCopy() const OVERRIDE;
and then swap with values_?

[raymes, 2012/04/06 23:22:47]

Done.

+    base::Value* value;
+    fields.values_.Get(i, &value);
+    values_.Append(value->DeepCopy());
+  }
+}
+
 void PPB_X509Certificate_Fields::SetField(
     PP_X509Certificate_Private_Field field,
     base::Value* value) {
   uint32_t index = static_cast<uint32_t>(field);
   bool success = values_.Set(index, value);
   DCHECK(success);
 }
 
 PP_Var PPB_X509Certificate_Fields::GetFieldAsPPVar(
     PP_X509Certificate_Private_Field field) const {
@@ skipping 53 matching lines @@
 //------------------------------------------------------------------------------
 
 PPB_X509Certificate_Private_Shared::PPB_X509Certificate_Private_Shared(
     ResourceObjectType type,
     PP_Instance instance) : Resource(type, instance), fields_(NULL) {
 }
 
 PPB_X509Certificate_Private_Shared::PPB_X509Certificate_Private_Shared(
     ResourceObjectType type,
     PP_Instance instance,
-    PPB_X509Certificate_Fields* fields)
-    : Resource(type, instance),
-      fields_(fields) {
+    const PPB_X509Certificate_Fields& fields)
+        : Resource(type, instance),

[yzshen1, 2012/04/06 19:24:33]

I think the convention is to *not* add 4 more spaces in this case.

[raymes, 2012/04/06 23:22:47]

Done.

+          fields_(new PPB_X509Certificate_Fields(fields))
+    {

[yzshen1, 2012/04/06 19:24:33]

And move it to the end of the previous line.

[raymes, 2012/04/06 23:22:47]

Done.

 }
 
 PPB_X509Certificate_Private_Shared::~PPB_X509Certificate_Private_Shared() {
 }
 
 thunk::PPB_X509Certificate_Private_API*
 PPB_X509Certificate_Private_Shared::AsPPB_X509Certificate_Private_API() {
   return this;
 }
 
@@ skipping 29 matching lines @@
     const std::vector<char>& der,
     PPB_X509Certificate_Fields* result) {
   // A concrete PPB_X509Certificate_Private_Shared should only ever be
   // constructed by passing in PPB_X509Certificate_Fields, in which case it is
   // already initialized.
   CHECK(false);
   return false;
 }
 
 }  // namespace ppapi