skia/ext: Add SK_API to a function used from a test

skia/ext: Add SK_API to a function used from a test

BUG=90078
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127068

[Jeff Timanus, 2012-03-15 18:47:38]

LGTM with an observation.

http://codereview.chromium.org/9699078/diff/1/skia/ext/bitmap_platform_device...
File skia/ext/bitmap_platform_device_mac.h (right):

http://codereview.chromium.org/9699078/diff/1/skia/ext/bitmap_platform_device...
skia/ext/bitmap_platform_device_mac.h:32: SK_API
The linux port is not exported.  On the windows port, the entire class is
exported.  Is it worth just exporting the whole class, to mirror the windows
behaviour?

[vandebo (ex-Chrome), 2012-03-15 18:48:03]

Sorry was out this morning.  Can you put the SK_API on the class?  If not, LGTM.

[Nico, 2012-03-15 20:06:52]

On 2012/03/15 18:48:03, vandebo wrote:
> Sorry was out this morning.  Can you put the SK_API on the class?  If not,
LGTM.

Done. Why is this preferred?

[commit-bot: I haz the power, 2012-03-15 20:17:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/9699078/2002

[Jeff Timanus, 2012-03-15 20:19:23]

On 2012/03/15 20:06:52, Nico wrote:
> On 2012/03/15 18:48:03, vandebo wrote:
> > Sorry was out this morning.  Can you put the SK_API on the class?  If not,
> LGTM.
> 
> Done. Why is this preferred?

I suggested it simply for the sake of consistency between the ports.  It's quite
possible that the windows version only needs export of a single function as
well.

Maintenance of the skia/ext classes is already convoluted, without further
divergence of the platform ports.

[vandebo (ex-Chrome), 2012-03-15 20:24:48]

On 2012/03/15 20:06:52, Nico wrote:
> On 2012/03/15 18:48:03, vandebo wrote:
> > Sorry was out this morning.  Can you put the SK_API on the class?  If not,
> LGTM.
> 
> Done. Why is this preferred?

AFAIK, Mike didn't want to have a lot of churn to add this kind of support, so
the minimal thing is to just add it on any class that needs it.  Also,
skia/include are supposed to be public headers, where as skia/src/*/*.h are
private headers.  i.e. anythin in skia/include should be fully exported.  (Of
course this doesn't directly apply in skia/ext.)

[commit-bot: I haz the power, 2012-03-16 01:33:18]

Change committed as 127068