net/base/x509_certificate_mac.cc - Issue 9699058: When detecting client certs on OS X, ensure all certs match the server's CertificateRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/x509_certificate_mac.cc

Issue 9699058: When detecting client certs on OS X, ensure all certs match the server's CertificateRequest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/x509_certificate_mac.cc

diff --git a/net/base/x509_certificate_mac.cc b/net/base/x509_certificate_mac.cc

index 1f8103f08be21aaf14ee51741fcf99c4388c0e3c..43e9f6158333ff72033edf369255968f9b63bb6e 100644

--- a/net/base/x509_certificate_mac.cc

+++ b/net/base/x509_certificate_mac.cc

@@ -1493,9 +1493,7 @@ bool X509Certificate::GetSSLClientCertificates(

CFEqual(preferred_identity, identity);

// Make sure the issuer matches valid_issuers, if given.

- // But an explicit cert preference overrides this.

- if (!is_preferred &&

- !valid_issuers.empty() &&

+ if (!valid_issuers.empty() &&

!cert->IsIssuedBy(valid_issuers))

wtc 2012/03/15 01:44:53 Nit: this conditional expression should fit in one

continue;

« no previous file with comments | « no previous file | no next file » | no next file with comments »