[Mac] Make ExtensionPopupController is-a BaseBubbleController to unify code.

[Mac] Make ExtensionPopupController is-a BaseBubbleController to unify code.

BUG=36366
TEST=Everything about extensions works as before.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126911

[Nico, 2012-03-14 21:26:17]

Awesome!

LGTM, two comments below

https://chromiumcodereview.appspot.com/9699045/diff/1/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm (left):

https://chromiumcodereview.appspot.com/9699045/diff/1/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm:126:
beingInspected_ = devMode;
wow

https://chromiumcodereview.appspot.com/9699045/diff/1/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm:181:
[[NSNotificationCenter defaultCenter] removeObserver:self];
Keeping this is probably nicer, since the class still registers itself for a
frame change notification

https://chromiumcodereview.appspot.com/9699045/diff/1/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm (right):

https://chromiumcodereview.appspot.com/9699045/diff/1/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm:138:
static_cast<InfoBubbleView*>(self.window.contentView);
DCHECK isKindOfClass

[Robert Sesek, 2012-03-14 23:56:41]

https://chromiumcodereview.appspot.com/9699045/diff/1/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm (left):

https://chromiumcodereview.appspot.com/9699045/diff/1/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm:181:
[[NSNotificationCenter defaultCenter] removeObserver:self];
On 2012/03/14 21:26:17, Nico wrote:
> Keeping this is probably nicer, since the class still registers itself for a
> frame change notification

Done.

https://chromiumcodereview.appspot.com/9699045/diff/1/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm (right):

https://chromiumcodereview.appspot.com/9699045/diff/1/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm:138:
static_cast<InfoBubbleView*>(self.window.contentView);
On 2012/03/14 21:26:17, Nico wrote:
> DCHECK isKindOfClass

Switched to using BaseBubbleController.bubble instead / Done-ish.

[commit-bot: I haz the power, 2012-03-15 00:04:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/9699045/1007

[commit-bot: I haz the power, 2012-03-15 04:25:34]

Try job failure for 9699045-1007 (previous was lost) (previous was lost) (retry)
on win for step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-03-15 04:28:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/9699045/1007

[commit-bot: I haz the power, 2012-03-15 05:37:46]

Try job failure for 9699045-1007 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-03-15 12:42:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/9699045/1007

[commit-bot: I haz the power, 2012-03-15 15:10:18]

Change committed as 126911