chrome/browser/resources/print_preview/print_preview.js - Issue 9699040: PrintPreview: Hide/Show the header footer option based on print frame margins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 9699040: PrintPreview: Hide/Show the header footer option based on print frame margins. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/header_footer_settings.js ('K') | « chrome/browser/resources/print_preview/header_footer_settings.js ('k') | chrome/browser/ui/webui/print_preview/print_preview_ui.h » ('j') | chrome/test/data/webui/print_preview.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/print_preview.js

diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js

index d39d666e4924aa39738980a91ad31d8619eba303..ede43d63cc4c571a68527842be7aaa32499ce151 100644

--- a/chrome/browser/resources/print_preview/print_preview.js

+++ b/chrome/browser/resources/print_preview/print_preview.js

@@ -872,8 +872,12 @@ function onDidGetPreviewPageCount(pageCount, previewResponseId) {

* in points.

* @param {boolean} hasCustomPageSizeStyle Indicates whether the previewed

* document has a custom page size style.

+ * @param {boolean} headerFooterApplies Indicates whether the header

+ * footer is applicable for the given settings.

-function onDidGetDefaultPageLayout(pageLayout, hasCustomPageSizeStyle) {

+function onDidGetDefaultPageLayout(pageLayout,

+ hasCustomPageSizeStyle,

+ headerFooterApplies) {

hasPageSizeStyle = hasCustomPageSizeStyle;

marginSettings.currentDefaultPageLayout = new print_preview.PageLayout(

pageLayout.contentWidth,

@@ -882,6 +886,7 @@ function onDidGetDefaultPageLayout(pageLayout, hasCustomPageSizeStyle) {

pageLayout.marginTop,

pageLayout.marginRight,

pageLayout.marginBottom);

+ headerFooterSettings.setVisibility(headerFooterApplies);

}

/**