PrintPreview: Hide/Show the header footer option based on print frame margins.

chrome/browser/resources/print_preview/header_footer_settings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Creates a HeaderFooterSettings object. This object encapsulates all
    * settings and logic related to the headers and footers checkbox.
@@ skipping 15 matching lines @@
      */
     get headerFooterCheckbox() {
       return this.headerFooterCheckbox_;
     },
 
     /**
      * Checks whether the Headers and Footers checkbox is checked or not.
      * @return {boolean} true if Headers and Footers are checked.
      */
     hasHeaderFooter: function() {
-      return this.headerFooterApplies_ && this.headerFooterCheckbox_.checked;
+      return previewModifiable && this.headerFooterCheckbox_.checked;
     },
 
     /**
      * Sets the state of the headers footers checkbox.
      * @param {boolean} checked True if the headers footers checkbox shoule be
      *     checked, false if not.
      */
     setChecked: function(checked) {
       this.headerFooterCheckbox_.checked = checked;
     },
 
     /**
      * Adding listeners to header footer related controls.
      * @private
      */
     addEventListeners_: function() {
       this.headerFooterCheckbox_.onclick =
           this.onHeaderFooterChanged_.bind(this);
       document.addEventListener(customEvents.PDF_LOADED,
                                 this.onPDFLoaded_.bind(this));
-      document.addEventListener(customEvents.MARGINS_SELECTION_CHANGED,

[kmadhusu, 2012/03/14 22:10:14]

This event is no longer required. So removed the corresponding code from
margin_settings.js

-                                this.onMarginsSelectionChanged_.bind(this));
     },
 
-    onMarginsSelectionChanged_: function(event) {
-      this.headerFooterApplies_ = event.selectedMargins !=

[dpapad, 2012/03/14 21:15:17]

Can you explain what happens now when NO_MARGINS is selected? Are you handling
this in the c++ side now?

[kmadhusu, 2012/03/14 22:10:14]

Yes. It is handled on C++ side. When NO_MARGINS is selected, we always hide the
header footer option. 

-          print_preview.MarginSettings.MARGINS_VALUE_NO_MARGINS;
+    /**
+     * Sets the visibility of header footer option.
+     * @param {boolean} headerFooterApplies True if the headers footers
+     *     checkbox shoud be hidden, else false.
+     */
+    setVisibility: function(headerFooterApplies) {
+      this.headerFooterApplies_ = headerFooterApplies;

[dpapad, 2012/03/14 21:15:17]

This member variable seems to only be used here. Can't it just be a local var?

[kmadhusu, 2012/03/14 22:10:14]

oops... Fixed. Removed the member variable. 

       this.setVisible_(this.headerFooterApplies_);
     },
 
     /**
      * Listener executing when the user selects or de-selects the headers
      * and footers option.
      * @private
      */
     onHeaderFooterChanged_: function() {
       requestPrintPreview();
@@ skipping 19 matching lines @@
         fadeInOption(this.headerFooterOption_);
       else
         fadeOutOption(this.headerFooterOption_);
     }
   };
 
   return {
     HeaderFooterSettings: HeaderFooterSettings
   };
 });