Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: chrome/browser/ui/panels/panel_overflow_browsertest.cc

Issue 9699036: Fix handling of minimized panel count (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_overflow_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_overflow_browsertest.cc b/chrome/browser/ui/panels/panel_overflow_browsertest.cc
index 0ef6e136297f1498f4653b0172276c3c28e0ce85..5f4d68fbce68b9f2ca10b4983ad7d2cfc0662ed3 100644
--- a/chrome/browser/ui/panels/panel_overflow_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_overflow_browsertest.cc
@@ -354,6 +354,43 @@ IN_PROC_BROWSER_TEST_F(PanelOverflowBrowserTest,
PanelManager::GetInstance()->CloseAll();
}
+IN_PROC_BROWSER_TEST_F(PanelOverflowBrowserTest, AddMinimizedTillOverflow) {
+ PanelManager* panel_manager = PanelManager::GetInstance();
+ DockedPanelStrip* docked_strip = panel_manager->docked_strip();
+ OverflowPanelStrip* overflow_strip = panel_manager->overflow_strip();
+
+ EXPECT_EQ(0, panel_manager->num_panels());
+ EXPECT_EQ(0, docked_strip->num_panels());
+ EXPECT_EQ(0, overflow_strip->num_panels());
+
+ CreatePanelParams params("Test", gfx::Rect(0, 0, 100, 100), SHOW_AS_INACTIVE);
jennb 2012/03/14 23:27:59 Add comment explaining why test does not want to w
+
jennb 2012/03/14 23:27:59 nit: delete blank line
+ params.wait_for_fully_created = false;
+
+ unsigned int num_panels_to_add = 10;
+ unsigned int num_panels = 0;
+ for (; num_panels < num_panels_to_add; ++num_panels) {
+ Panel* panel = CreatePanelWithParams(params);
+ panel->SetExpansionState(Panel::MINIMIZED);
+
+ panel->panel_strip()->RemovePanel(panel);
+ EXPECT_EQ(NULL, panel->panel_strip());
+ panel->set_has_temporary_layout(false);
+
+ docked_strip->AddPanel(panel, PanelStrip::DEFAULT_POSITION);
+ EXPECT_EQ(Panel::MINIMIZED, panel->expansion_state());
+ EXPECT_EQ(false, panel->has_temporary_layout());
+ }
+
+ EXPECT_EQ(num_panels_to_add, num_panels);
+ EXPECT_EQ(0, docked_strip->num_temporary_layout_panels());
+ EXPECT_EQ(num_panels, static_cast<unsigned int>
+ (docked_strip->minimized_panel_count() +
+ overflow_strip->num_panels()));
+
+ PanelManager::GetInstance()->CloseAll();
+}
+
IN_PROC_BROWSER_TEST_F(PanelOverflowBrowserTest,
CreatePanelOnDelayedOverflow) {
// Create 2 big panels.
« no previous file with comments | « chrome/browser/ui/panels/panel_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698