Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 9699034: Enable new media perf pyauto tests. (Closed)

Created:
8 years, 9 months ago by shadi1
Modified:
8 years, 9 months ago
CC:
chromium-reviews, dennis_jeffrey, John Grabowski, anantha, dyu1, Nirnimesh
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enable new media perf pyauto tests. BUG=110779 TEST=Ran on perf bot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126801

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
shadi1
Nirnimesh, can you please enable those tests for media perf. Thanks.
8 years, 9 months ago (2012-03-14 17:07:14 UTC) #1
dennis_jeffrey
Nirnimesh is OOO. Want me to approve it? I just had 1 nit below. https://chromiumcodereview.appspot.com/9699034/diff/1/chrome/test/functional/PYAUTO_TESTS ...
8 years, 9 months ago (2012-03-14 17:25:50 UTC) #2
shadi1
Thanks Dennis! https://chromiumcodereview.appspot.com/9699034/diff/1/chrome/test/functional/PYAUTO_TESTS File chrome/test/functional/PYAUTO_TESTS (right): https://chromiumcodereview.appspot.com/9699034/diff/1/chrome/test/functional/PYAUTO_TESTS#newcode682 chrome/test/functional/PYAUTO_TESTS:682: 'media.media_jerky', On 2012/03/14 17:25:50, dennis_jeffrey wrote: > ...
8 years, 9 months ago (2012-03-14 18:02:06 UTC) #3
dennis_jeffrey
LGTM
8 years, 9 months ago (2012-03-14 18:09:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@google.com/9699034/3001
8 years, 9 months ago (2012-03-14 21:55:13 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 00:21:24 UTC) #6
Change committed as 126801

Powered by Google App Engine
This is Rietveld 408576698