Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 9699018: Build Java everywhere for Android builds (Closed)

Created:
8 years, 9 months ago by Peter Beverloo
Modified:
8 years, 9 months ago
Reviewers:
Mark Mentovai, Yaron, Satish
CC:
chromium-reviews, brettw-cc_chromium.org, John Grabowski, navabi, bulach
Visibility:
Public.

Description

Build Java files as part of the base target for Android builds Move the dependency to the base target, causing Java to be compiled on all configurations (including trybots and the main waterfall bot). We currently build two source files. BUG= TEST=Build output should execute the "base_java" action. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126693

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated description #

Patch Set 3 : Rebase? #

Patch Set 4 : Moved the dependency to work around the merge comflict. #

Patch Set 5 : Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/base.gypi View 4 1 chunk +1 line, -0 lines 0 comments Download
M build/all_android.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Peter Beverloo
8 years, 9 months ago (2012-03-14 11:54:11 UTC) #1
Yaron
lgtm Just one thought for future work. https://chromiumcodereview.appspot.com/9699018/diff/1/base/base.gypi File base/base.gypi (right): https://chromiumcodereview.appspot.com/9699018/diff/1/base/base.gypi#newcode667 base/base.gypi:667: 'android/java/java.gyp:base_java', I ...
8 years, 9 months ago (2012-03-14 11:58:01 UTC) #2
Satish
lgtm
8 years, 9 months ago (2012-03-14 12:09:32 UTC) #3
Peter Beverloo
Cheers. Since this enables Java on the try-bots and CQ as well, these will be ...
8 years, 9 months ago (2012-03-14 12:12:00 UTC) #4
Peter Beverloo
On 2012/03/14 12:12:00, Peter Beverloo wrote: > Cheers. Since this enables Java on the try-bots ...
8 years, 9 months ago (2012-03-14 13:43:41 UTC) #5
Mark Mentovai
LGTM
8 years, 9 months ago (2012-03-14 15:49:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/9699018/9
8 years, 9 months ago (2012-03-14 15:51:00 UTC) #7
commit-bot: I haz the power
Try job failure for 9699018-9 (retry) (retry) on linux_rel for step "remoting_unittests". It's a second ...
8 years, 9 months ago (2012-03-14 16:56:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/9699018/9
8 years, 9 months ago (2012-03-14 16:57:53 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 19:01:38 UTC) #10
Change committed as 126693

Powered by Google App Engine
This is Rietveld 408576698