Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 9696049: Add enable_automation build switch. (Closed)

Created:
8 years, 9 months ago by Xianzhu
Modified:
8 years, 9 months ago
CC:
chromium-reviews, creis+watch_chromium.org, Avi (use Gerrit), ajwong+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add enable_automation build switch. It's only disabled on Android to exclude automation from Android build. enable_automation=0 still doesn't work on platforms other than Android. BUG=117407 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127004

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge two #if defined(ENABLE_AUTOMATION) in browser_init.cc #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -37 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 4 chunks +40 lines, -35 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Xianzhu
8 years, 9 months ago (2012-03-13 21:07:28 UTC) #1
Xianzhu
8 years, 9 months ago (2012-03-14 16:59:46 UTC) #2
Xianzhu
@jam, does the way to exclude automation look good to you? I tried to minimize ...
8 years, 9 months ago (2012-03-14 17:35:13 UTC) #3
jam
lgtm http://codereview.chromium.org/9696049/diff/1/chrome/browser/ui/browser_init.cc File chrome/browser/ui/browser_init.cc (right): http://codereview.chromium.org/9696049/diff/1/chrome/browser/ui/browser_init.cc#newcode1764 chrome/browser/ui/browser_init.cc:1764: bool silent_launch = false; nit: move this to ...
8 years, 9 months ago (2012-03-14 17:48:13 UTC) #4
Xianzhu
http://codereview.chromium.org/9696049/diff/1/chrome/browser/ui/browser_init.cc File chrome/browser/ui/browser_init.cc (right): http://codereview.chromium.org/9696049/diff/1/chrome/browser/ui/browser_init.cc#newcode1764 chrome/browser/ui/browser_init.cc:1764: bool silent_launch = false; On 2012/03/14 17:48:13, John Abd-El-Malek ...
8 years, 9 months ago (2012-03-14 18:02:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/9696049/7001
8 years, 9 months ago (2012-03-14 18:02:47 UTC) #6
commit-bot: I haz the power
Presubmit check for 9696049-7001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-14 18:02:53 UTC) #7
Xianzhu
@ben, could you review this change? It needs an approval from OWNERS of chrome/browser/ui.
8 years, 9 months ago (2012-03-14 18:06:37 UTC) #8
Xianzhu
8 years, 9 months ago (2012-03-15 17:18:01 UTC) #9
Xianzhu
@ben, @pkasting and @sky, could you review this change? It needs an approval from OWNERS ...
8 years, 9 months ago (2012-03-15 17:20:00 UTC) #10
sky
LGTM
8 years, 9 months ago (2012-03-15 17:30:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/9696049/7001
8 years, 9 months ago (2012-03-15 17:39:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/9696049/6002
8 years, 9 months ago (2012-03-15 18:01:57 UTC) #13
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 21:53:12 UTC) #14
Change committed as 127004

Powered by Google App Engine
This is Rietveld 408576698