Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 9695016: Handle errors in posting sync commit messages (Closed)

Created:
8 years, 9 months ago by rlarocque
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Handle errors in posting sync commit messages This fixes an oversight in r117285. That commit should have included these changes, but the diffs were accidentally misplaced. Prior to this commit, all PostCommitMessage tasks would seem to have succeeded. However, this bug did not affect the return values from ProcessCommitResponseCommand, so the syncer should be able to detect commit failures even without this fix. BUG=117893 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/sync/engine/post_commit_message_command.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rlarocque
Fixes an issue resulting from bad diff management when fixing SYNC_CYCLE_CONTINUATION errors. See http://codereview.chromium.org/9158004. Please ...
8 years, 9 months ago (2012-03-12 22:27:16 UTC) #1
tim (not reviewing)
LGTM
8 years, 9 months ago (2012-03-13 00:40:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/9695016/1
8 years, 9 months ago (2012-03-13 17:52:43 UTC) #3
commit-bot: I haz the power
Try job failure for 9695016-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-13 20:29:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/9695016/1
8 years, 9 months ago (2012-03-13 20:33:47 UTC) #5
commit-bot: I haz the power
Try job failure for 9695016-1 (previous was lost) (retry) on win_rel for step "browser_tests". It's ...
8 years, 9 months ago (2012-03-13 23:53:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/9695016/1
8 years, 9 months ago (2012-03-14 17:57:22 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 19:15:59 UTC) #8
Change committed as 126701

Powered by Google App Engine
This is Rietveld 408576698