Issue 9694057: Fix arguments passed to FileEntry.copyTo() and FileEntry.moveTo().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9694057: Fix arguments passed to FileEntry.copyTo() and FileEntry.moveTo(). (Closed)

Created:
8 years, 9 months ago by Ben Chan

Modified:
8 years, 9 months ago

Reviewers:
rginda, dgozman

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix arguments passed to FileEntry.copyTo() and FileEntry.moveTo(). The copyTo() and moveTo() function in FileEntry takes a DirectoryEntry argument and an optional new name argument. The name argument is used to specify the file name, which should not contain any directory components. This CL fixes a failed invocation of copyTo() due to a path with directory components being passed as the name argument. The CL also chanegs the code to pass the correct form of callback to copyTo() and moveTo(). BUG=chromium-os:26962 TEST=TEST=Manually tested copy, move, and rename operations on GData mount point. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126669

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -4 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_copy_manager.js	View		3 chunks	+68 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/9694057/1

8 years, 9 months ago (2012-03-14 14:17:17 UTC) #3

Change committed as 126669

Expand Messages | Collapse Messages