OBSOLETE REVIEW. See http://codereview.chromium.org/10382149/

chrome/browser/extensions/extension_prefs.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 #pragma once
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/memory/linked_ptr.h"
 #include "base/time.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_content_settings_store.h"
+#include "chrome/browser/extensions/extension_management_policy.h"
 #include "chrome/browser/extensions/extension_prefs_scope.h"
 #include "chrome/browser/extensions/extension_scoped_prefs.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/string_ordinal.h"
 
 class ExtensionPrefValueMap;
 class ExtensionSorting;
 class PrefService;
 class URLPatternSet;
 
@@ skipping 11 matching lines @@
 // - per-extension preferences:
 //       meta-preferences describing properties of the extension like
 //       installation time, whether the extension is enabled, etc.
 // - extension controlled preferences:
 //       browser preferences that an extension controls. For example, an
 //       extension could use the proxy API to specify the browser's proxy
 //       preference. Extension-controlled preferences are stored in
 //       PrefValueStore::extension_prefs(), which this class populates and
 //       maintains as the underlying extensions change.
 class ExtensionPrefs : public ExtensionContentSettingsStore::Observer,
+                       public ExtensionManagementPolicy::Delegate,
                        public ExtensionScopedPrefs {
  public:
   // Key name for a preference that keeps track of per-extension settings. This
   // is a dictionary object read from the Preferences file, keyed off of
   // extension ids.
   static const char kExtensionsPref[];
 
   typedef std::vector<linked_ptr<ExtensionInfo> > ExtensionsInfo;
 
   // Vector containing identifiers for preferences.
@@ skipping 137 matching lines @@
 
   // The oauth client id used for app notification setup, if any.
   std::string GetAppNotificationClientId(const std::string& extension_id) const;
   void SetAppNotificationClientId(const std::string& extension_id,
                                   const std::string& oauth_client_id);
 
   // Whether app notifications are disabled for the given app.
   bool IsAppNotificationDisabled(const std::string& extension_id) const;
   void SetAppNotificationDisabled(const std::string& extension_id, bool value);
 
-  // Is the extension with |extension_id| allowed by policy (checking both
-  // whitelist and blacklist).
-  bool IsExtensionAllowedByPolicy(const std::string& extension_id,
-                                  Extension::Location location) const;
+  // ExtensionManagementPolicy::Delegate implementation:

[Aaron Boodman, 2012/05/17 22:41:06]

We usually just say:

// ExtensionManagementPolicy::Delegate

+  // Returns true if the extension with |extension_id| is allowed by policy

[Aaron Boodman, 2012/05/17 22:41:06]

I don't think this comment is necessary since the interface will describe what
this is supposed to do, and the rest of the comment is impl detail.

[Pam (message me for reviews), 2012/05/18 20:15:15]

I clarified that this particular management policy provider is checking the
admin policy.

+  // (checking both whitelist and blacklist).
+  virtual bool UserMayInstall(const std::string& extension_id,
+                              Extension::Location location,
+                              const std::string& extension_name,
+                              string16* error) const OVERRIDE;
 
   // Checks if extensions are blacklisted by default, by policy. When true, this
   // means that even extensions without an ID should be blacklisted (e.g.
   // from the command line, or when loaded as an unpacked extension).
   // IsExtensionAllowedByPolicy() also takes this into account, and should be
   // used instead when the extension ID is known.
   bool ExtensionsBlacklistedByDefault() const;
 
   // Returns the last value set via SetLastPingDay. If there isn't such a
   // pref, the returned Time will return true for is_null().
@@ skipping 317 matching lines @@
   // Contains all the logic for handling the order for various extension
   // properties.
   scoped_ptr<ExtensionSorting> extension_sorting_;
 
   scoped_refptr<ExtensionContentSettingsStore> content_settings_store_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_