Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2166)

Unified Diff: chrome/browser/ui/webui/options2/search_engine_manager_handler2.cc

Issue 9693032: [uber page] Split up initialization of handlers from initialization of webui pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options2/search_engine_manager_handler2.cc
diff --git a/chrome/browser/ui/webui/options2/search_engine_manager_handler2.cc b/chrome/browser/ui/webui/options2/search_engine_manager_handler2.cc
index 999269a67d43d6d739d500db386468cb770e8335..cf0a6ad85503f349dfcfa60bca66a85561c97462 100644
--- a/chrome/browser/ui/webui/options2/search_engine_manager_handler2.cc
+++ b/chrome/browser/ui/webui/options2/search_engine_manager_handler2.cc
@@ -44,10 +44,12 @@ SearchEngineManagerHandler::~SearchEngineManagerHandler() {
void SearchEngineManagerHandler::Initialize() {
list_controller_.reset(
new KeywordEditorController(Profile::FromWebUI(web_ui())));
- if (list_controller_.get()) {
- list_controller_->table_model()->SetObserver(this);
- OnModelChanged();
- }
+ DCHECK(list_controller_.get());
+ list_controller_->table_model()->SetObserver(this);
+}
+
+void SearchEngineManagerHandler::SendPageValues() {
+ OnModelChanged();
}
void SearchEngineManagerHandler::GetLocalizedValues(
@@ -115,6 +117,7 @@ void SearchEngineManagerHandler::RegisterMessages() {
}
void SearchEngineManagerHandler::OnModelChanged() {
+ DCHECK(list_controller_.get());
if (!list_controller_->loaded())
return;

Powered by Google App Engine
This is Rietveld 408576698