[uber page] Split up initialization of handlers from initialization of webui pages

chrome/browser/ui/webui/options2/import_data_handler2.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options2/import_data_handler2.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 14 matching lines @@
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace options2 {
 
 ImportDataHandler::ImportDataHandler() : importer_host_(NULL),
                                          import_did_succeed_(false) {
 }
 
 ImportDataHandler::~ImportDataHandler() {
-  if (importer_list_)
+  if (importer_list_.get())
     importer_list_->SetObserver(NULL);
 
   if (importer_host_)
     importer_host_->SetObserver(NULL);
 }
 
 void ImportDataHandler::GetLocalizedValues(DictionaryValue* localized_strings) {
   DCHECK(localized_strings);
 
   static OptionsStringResource resources[] = {
     { "importFromLabel", IDS_IMPORT_FROM_LABEL },
     { "importLoading", IDS_IMPORT_LOADING_PROFILES },
     { "importDescription", IDS_IMPORT_ITEMS_LABEL },
     { "importHistory", IDS_IMPORT_HISTORY_CHKBOX },
     { "importFavorites", IDS_IMPORT_FAVORITES_CHKBOX },
     { "importSearch", IDS_IMPORT_SEARCH_ENGINES_CHKBOX },
     { "importPasswords", IDS_IMPORT_PASSWORDS_CHKBOX },
     { "importCommit", IDS_IMPORT_COMMIT },
     { "noProfileFound", IDS_IMPORT_NO_PROFILE_FOUND },
     { "importSucceeded", IDS_IMPORT_SUCCEEDED },
     { "findYourImportedBookmarks", IDS_IMPORT_FIND_YOUR_BOOKMARKS },
   };
 
   RegisterStrings(localized_strings, resources, arraysize(resources));
   RegisterTitle(localized_strings, "importDataOverlay",
                 IDS_IMPORT_SETTINGS_TITLE);
 }
 
-void ImportDataHandler::Initialize() {
+void ImportDataHandler::InitializeHandler() {
   Profile* profile = Profile::FromWebUI(web_ui());
   importer_list_ = new ImporterList(profile->GetRequestContext());
   importer_list_->DetectSourceProfiles(this);
 }
 
 void ImportDataHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback("importData",
       base::Bind(&ImportDataHandler::ImportData, base::Unretained(this)));
 }
 
@@ skipping 46 matching lines @@
     importer_host_->StartImportSettings(source_profile, profile,
                                         import_services,
                                         new ProfileWriter(profile), false);
   } else {
     LOG(WARNING) << "There were no settings to import from '"
         << source_profile.importer_name << "'.";
   }
 }
 
 void ImportDataHandler::OnSourceProfilesLoaded() {
+  InitializePage();
+}
+
+void ImportDataHandler::InitializePage() {
+  if (!importer_list_->source_profiles_loaded())
+    return;
+
   ListValue browser_profiles;
   for (size_t i = 0; i < importer_list_->count(); ++i) {
     const importer::SourceProfile& source_profile =
         importer_list_->GetSourceProfileAt(i);
     uint16 browser_services = source_profile.services_supported;
 
     DictionaryValue* browser_profile = new DictionaryValue();
     browser_profile->SetString("name", source_profile.importer_name);
     browser_profile->SetInteger("index", i);
     browser_profile->SetBoolean("history",
@@ skipping 32 matching lines @@
     web_ui()->CallJavascriptFunction("ImportDataOverlay.confirmSuccess");
   } else {
     base::FundamentalValue state(false);
     web_ui()->CallJavascriptFunction("ImportDataOverlay.setImportingState",
                                      state);
     web_ui()->CallJavascriptFunction("ImportDataOverlay.dismiss");
   }
 }
 
 }  // namespace options2