[uber page] Split up initialization of handlers from initialization of webui pages

chrome/browser/ui/webui/options/options_ui.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_OPTIONS_UI_H_
 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_OPTIONS_UI_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 17 matching lines @@
   // Is this handler enabled?
   virtual bool IsEnabled();
 
   // Collects localized strings for options page.
   virtual void GetLocalizedValues(base::DictionaryValue* localized_strings) = 0;
 
   // Initialize the page.  Called once the DOM is available for manipulation.
   // This will be called only once.
   virtual void Initialize() {}
 
+  // Actually sends down values after initialization to the webui page.

[Evan Stade, 2012/03/13 20:44:50]

expand comment to highlight differences between this and initialize()

[csilv, 2012/03/13 20:59:49]

nit: remove the word "Actually".

[Dan Beam, 2012/03/13 23:01:45]

Done.

[Dan Beam, 2012/03/13 23:01:45]

Done.

+  virtual void SendPageValues() {}

[Evan Stade, 2012/03/13 20:44:50]

I am not too keen on this name. How about:

RefreshPageState()

UpdatePageState()

etc.

Or, you could change the two functions to be

InitializeHandler/InitializePage instead of Initialize/SendPageValues

[csilv, 2012/03/13 20:59:49]

I had the same reaction to the method name.

I really like Evan's suggestion to use InitializeHandler/InitializePage

[Dan Beam, 2012/03/13 23:01:45]

Done.

+
   // Uninitializes the page.  Called just before the object is destructed.
   virtual void Uninitialize() {}
 
   // WebUIMessageHandler implementation.
   virtual void RegisterMessages() OVERRIDE {}
 
   // content::NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE {}
@@ skipping 60 matching lines @@
   void SetCommandLineString(content::RenderViewHost* render_view_host);
 
   bool initialized_handlers_;
 
   std::vector<OptionsPageUIHandler*> handlers_;
 
   DISALLOW_COPY_AND_ASSIGN(OptionsUI);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_OPTIONS_OPTIONS_UI_H_