Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 9693031: mac: fix flash videos with --disable-composited-core-animation-plugins (Closed)

Created:
8 years, 9 months ago by piman
Modified:
8 years, 9 months ago
Reviewers:
jam, apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

mac: fix flash videos with --disable-composited-core-animation-plugins http://codereview.chromium.org/9194005 Missed one renaming. This fixes it. BUG=117916 TEST=chrome --disable-composited-core-animation-plugins, load youtube videos Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/plugin_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
piman
apatrick: please review (trivial renames, only render_widget_host_mac.cc has a meaningful change which is also trivial) ...
8 years, 9 months ago (2012-03-13 03:04:58 UTC) #1
jam
lgtm
8 years, 9 months ago (2012-03-13 16:20:57 UTC) #2
apatrick_chromium
lgtm
8 years, 9 months ago (2012-03-13 18:11:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9693031/1
8 years, 9 months ago (2012-03-13 18:14:28 UTC) #4
commit-bot: I haz the power
Try job failure for 9693031-1 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-13 19:22:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9693031/1
8 years, 9 months ago (2012-03-13 19:37:02 UTC) #6
commit-bot: I haz the power
Try job failure for 9693031-1 (retry) (retry) on win_rel for step "browser_tests". It's a second ...
8 years, 9 months ago (2012-03-13 23:25:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9693031/1
8 years, 9 months ago (2012-03-13 23:32:56 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 04:24:33 UTC) #9
Change committed as 126560

Powered by Google App Engine
This is Rietveld 408576698