Add the PPAPI X509 Certificate interface and implementation.

ppapi/shared_impl/private/ppb_flash_x509_certificate_shared.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_SHARED_IMPL_PRIVATE_FLASH_X509_CERTIFICATE_IMPL_H_

[yzshen1, 2012/03/20 06:48:01]

You missed 'PPB_' in the middle.

[raymes, 2012/03/21 20:28:08]

Done.

+#define PPAPI_SHARED_IMPL_PRIVATE_FLASH_X509_CERTIFICATE_IMPL_H_
+
+#include <vector>
+
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "ppapi/c/private/ppb_flash_x509_certificate.h"
+#include "ppapi/shared_impl/resource.h"
+#include "ppapi/thunk/ppb_flash_x509_certificate_api.h"
+
+namespace IPC {
+template <class T>
+struct ParamTraits;
+}
+
+namespace ppapi {
+
+class PPB_X509Certificate_Fields {

[yzshen1, 2012/03/20 06:48:01]

It seems better to me to use base::ListValue to replace
PPB_X509Certificate_Fields. And move things like GetFieldAsPPVar into
PPB_Flash_X509Certificate_Shared.

You don't need to add IPC::ParamTraits in that case.

[raymes, 2012/03/21 20:28:08]

Hmm, I see your point. I think it's a tradeoff. I feel like this abstraction
makes it more obvious what this data is, especially on the browser side where we
would otherwise be constructing a raw base::ListValue without much context as to
how it should be constructed. 

Either way is fine with me, if you feel strongly I will change the code.

On 2012/03/20 06:48:01, yzshen1 wrote:

[yzshen1, 2012/03/22 23:32:40]

Okay. It is fine if you have thought it through.
On 2012/03/21 20:28:08, raymes wrote:

+ public:
+  virtual ~PPB_X509Certificate_Fields();

[yzshen1, 2012/03/20 06:48:01]

Will this be a base class? If not, please remove the virtual destructor.

[raymes, 2012/03/21 20:28:08]

Done.

+
+  // Takes ownership of |value|.
+  void SetField(PP_Flash_X509Certificate_Field field, base::Value* value);
+  PP_Var GetFieldAsPPVar(PP_Flash_X509Certificate_Field field) const;
+
+ private:
+  // Friend so ParamTraits can serialize us.
+  friend struct IPC::ParamTraits<ppapi::PPB_X509Certificate_Fields>;
+
+  base::ListValue values_;
+};
+
+//------------------------------------------------------------------------------
+
+class PPAPI_SHARED_EXPORT PPB_Flash_X509Certificate_Shared
+    : public thunk::PPB_Flash_X509Certificate_API,
+      public Resource {
+ public:
+  PPB_Flash_X509Certificate_Shared(ResourceObjectType type,
+                                   PP_Instance instance);
+  // Used by tcp_socket_shared_impl to construct a certificate resource from a
+  // server certificate. This object owns the pointer passed in.
+  PPB_Flash_X509Certificate_Shared(ResourceObjectType type,
+                                   PP_Instance instance,
+                                   PPB_X509Certificate_Fields* fields);
+  virtual ~PPB_Flash_X509Certificate_Shared();
+
+  // Resource overrides.
+  virtual PPB_Flash_X509Certificate_API*
+    AsPPB_Flash_X509Certificate_API() OVERRIDE;

[yzshen1, 2012/03/20 06:48:01]

Wrong indent.

[raymes, 2012/03/21 20:28:08]

Done.

+
+  // PPB_Flash_X509Certificate_API implementation.
+  virtual PP_Bool Init(const char* bytes, uint32_t length) OVERRIDE;
+  virtual PP_Var GetField(PP_Flash_X509Certificate_Field field) OVERRIDE;
+
+ protected:
+  virtual bool ParseDER(const std::vector<char>& der,
+                        PPB_X509Certificate_Fields* result);
+
+ private:
+  scoped_ptr<PPB_X509Certificate_Fields> fields_;
+
+  DISALLOW_COPY_AND_ASSIGN(PPB_Flash_X509Certificate_Shared);
+};
+
+}  // namespace ppapi
+
+#endif  // PPAPI_SHARED_IMPL_PRIVATE_FLASH_X509_CERTIFICATE_IMPL_H_