Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 9693023: Add unit_tests_run. (Closed)

Created:
8 years, 9 months ago by M-A Ruel
Modified:
8 years, 7 months ago
CC:
chromium-reviews, csharp
Visibility:
Public.

Description

Add unit_tests_run that (mostly) works for all of linux, OSX and Windows. The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py. Manual edits: - Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck. - Removed testserver.log and unit_tests.log. - Added copyright. - Removed *.db-journal files. R=rogerta@chromium.org BUG=98636 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134507

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : Now mostly working #

Patch Set 4 : Rebase against HEAD #

Patch Set 5 : Almost working #

Patch Set 6 : Rebased against HEAD #

Patch Set 7 : Final version #

Patch Set 8 : Fix mac make #

Patch Set 9 : Completely redone #

Patch Set 10 : mostly working #

Patch Set 11 : rebase against HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1107 lines, -0 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/unit_tests.isolate View 1 2 3 4 5 6 7 8 9 10 1 chunk +1077 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
M-A Ruel
chrome_tests.gypi doesn't really have an owner. Basically doing the same thing that for the other ...
8 years, 9 months ago (2012-03-13 00:15:26 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
8 years, 9 months ago (2012-03-13 02:32:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9693023/2001
8 years, 9 months ago (2012-03-13 02:35:54 UTC) #3
commit-bot: I haz the power
Try job failure for 9693023-2001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-13 03:33:19 UTC) #4
M-A Ruel
I cleaned up significantly. Inputs are now only defined in response_file action. No inputs, in ...
8 years, 9 months ago (2012-03-16 14:07:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9693023/9001
8 years, 9 months ago (2012-03-16 14:07:16 UTC) #6
commit-bot: I haz the power
Try job failure for 9693023-9001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-16 14:56:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9693023/9001
8 years, 9 months ago (2012-03-16 15:16:45 UTC) #8
commit-bot: I haz the power
Try job failure for 9693023-9001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-16 15:58:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9693023/9001
8 years, 9 months ago (2012-03-16 15:59:40 UTC) #10
commit-bot: I haz the power
Try job failure for 9693023-9001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-16 16:57:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9693023/36002
8 years, 7 months ago (2012-04-28 19:38:32 UTC) #12
commit-bot: I haz the power
Try job failure for 9693023-36002 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-04-28 20:16:20 UTC) #13
Nico
(Hadn't you given up on this approach?)
8 years, 7 months ago (2012-04-29 00:20:57 UTC) #14
M-A Ruel
On 2012/04/29 00:20:57, Nico wrote: > (Hadn't you given up on this approach?) No, I ...
8 years, 7 months ago (2012-04-29 00:42:09 UTC) #15
Nico
Does that mean http://crbug.com/117579 means this won't work with ninja? (trying to understand how important ...
8 years, 7 months ago (2012-04-29 00:44:06 UTC) #16
M-A Ruel
On 2012/04/29 00:44:06, Nico wrote: > Does that mean http://crbug.com/117579 means this won't work with ...
8 years, 7 months ago (2012-04-29 00:57:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9693023/36002
8 years, 7 months ago (2012-04-30 01:48:39 UTC) #18
commit-bot: I haz the power
Change committed as 134507
8 years, 7 months ago (2012-04-30 04:16:38 UTC) #19
M-A Ruel
8 years, 7 months ago (2012-04-30 13:00:26 UTC) #20
On 2012/04/30 04:16:38, I haz the power (commit-bot) wrote:
> Change committed as 134507

This CL was reverted in r134508. I'll have to look through all the builders and
fix them to have a proper checkout. :/

Powered by Google App Engine
This is Rietveld 408576698