Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 9693016: Enable goma for Android. Fix non-goma 'make' builds. (Closed)

Created:
8 years, 9 months ago by John Grabowski
Modified:
8 years, 9 months ago
Reviewers:
bulach, M-A Ruel
CC:
chromium-reviews, Peter Beverloo, Yaron
Visibility:
Public.

Description

Enable goma for Android. Fix non-goma 'make' builds. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127919

Patch Set 1 #

Patch Set 2 : fix goma_dir var and deal with make function #

Patch Set 3 : fix check for ndk/sdk to be friendlier #

Patch Set 4 : stop goma when done. move var settings earlier. #

Patch Set 5 : Add failsafe. Merge with recent bulach changes. Fix terminate. #

Patch Set 6 : removing make() add given merge with recent changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -20 lines) Patch
M build/android/buildbot_functions.sh View 1 2 3 4 6 chunks +40 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
John Grabowski
Notes: 1. per M-A's request it looks like this does in fact do clobber. I've ...
8 years, 9 months ago (2012-03-13 01:45:30 UTC) #1
bulach
I'm preparing to upstream the fixes I made to remove the make() function altogether, I'll ...
8 years, 9 months ago (2012-03-13 14:16:07 UTC) #2
M-A Ruel
lgtm
8 years, 9 months ago (2012-03-13 14:27:30 UTC) #3
John Grabowski
Thx for feedback. I'm going to wait until http://codereview.chromium.org/9693042/ works through CQ. Also, it looks ...
8 years, 9 months ago (2012-03-13 19:53:46 UTC) #4
John Grabowski
Ready for re-review if you have additional comments. Will try and land tonight.
8 years, 9 months ago (2012-03-20 21:59:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrg@chromium.org/9693016/11003
8 years, 9 months ago (2012-03-21 05:33:09 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-21 07:09:51 UTC) #7
Change committed as 127919

Powered by Google App Engine
This is Rietveld 408576698