Issue 9692070: Ensure both PanelBrowserWindowGtk and BalloonCollectionImpl call RemoveObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9692070: Ensure both PanelBrowserWindowGtk and BalloonCollectionImpl call RemoveObserver. (Closed)

Created:
8 years, 9 months ago by jianli

Modified:
8 years, 9 months ago

Reviewers:
jennb

CC:
chromium-reviews, Dmitry Lomov (no reviews), jennb, Dmitry Titov, jianli, dcheng, Andrei

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ensure both PanelBrowserWindowGtk and BalloonCollectionImpl call RemoveObserver. The fix is to ensure we do not miss calling MessageLoopForUI::RemoveObserver() in both destructors. BUG=117278 TEST=Manual verify both destructors contain the call. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126702

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/notifications/balloon_collection_impl.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/panels/panel_browser_window_gtk.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/9692070/1

8 years, 9 months ago (2012-03-14 07:04:40 UTC) #3

commit-bot: I haz the power

Try job failure for 9692070-1 (retry) on linux_rel for step "browser_tests". It's a second try, ...

8 years, 9 months ago (2012-03-14 07:57:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/9692070/1

8 years, 9 months ago (2012-03-14 17:45:06 UTC) #5

Change committed as 126702

Expand Messages | Collapse Messages