Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 9692059: Make presubmit ignore files that end in _autogen.h (Closed)

Created:
8 years, 9 months ago by greggman
Modified:
8 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Make presubmit ignore files that end in _autogen.h The GPU code generates relatively complicated code. We generate that code and check in the generated files to make it easy to use codereview to see what was generated makes sense. Unfortunately, keeping the generator always generating lint error free code is hard. We mark lines that have issues with // NOLINT but that feature has apparently been removed from our lint so instead we'd just like to have presubmit ignore *_autogen.h files. R=maruel@chromium.org BUG=none TEST=checked that it did indeed exclude *_autogen.h files Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hi M-A, PTAL
8 years, 9 months ago (2012-03-13 20:25:35 UTC) #1
M-A Ruel
lgtm
8 years, 9 months ago (2012-03-13 20:26:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/9692059/1
8 years, 9 months ago (2012-03-13 20:47:31 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 03:22:55 UTC) #4
Change committed as 126542

Powered by Google App Engine
This is Rietveld 408576698