Issue 9692022: If a subdir exists and is empty, go ahead and clone into it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9692022: If a subdir exists and is empty, go ahead and clone into it. (Closed)

Created:
8 years, 9 months ago by szager

Modified:
8 years, 9 months ago

Reviewers:
Nicolas Sylvain, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

If a subdir exists and is empty, go ahead and clone into it. This will make it easier to support git-submodule and gclient at the same time. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126428

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	gclient_scm.py	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm https://chromiumcodereview.appspot.com/9692022/diff/1/gclient_scm.py File gclient_scm.py (right): https://chromiumcodereview.appspot.com/9692022/diff/1/gclient_scm.py#newcode223 gclient_scm.py:223: os.path.isdir(self.checkout_path) and \ remove \, not necessary.

8 years, 9 months ago (2012-03-12 23:54:59 UTC) #2

szager

https://chromiumcodereview.appspot.com/9692022/diff/1/gclient_scm.py File gclient_scm.py (right): https://chromiumcodereview.appspot.com/9692022/diff/1/gclient_scm.py#newcode223 gclient_scm.py:223: os.path.isdir(self.checkout_path) and \ On 2012/03/12 23:54:59, Marc-Antoine Ruel wrote: ...

8 years, 9 months ago (2012-03-13 00:00:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@google.com/9692022/3001

8 years, 9 months ago (2012-03-13 18:46:32 UTC) #4

Change committed as 126428

Expand Messages | Collapse Messages