dbus: allow unregistering of exported objects

dbus/bus.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // TODO(satorux):
 // - Handle "disconnected" signal.
 
 #include "dbus/bus.h"
 
 #include "base/bind.h"
@@ skipping 232 matching lines @@
     return iter->second;
   }
 
   scoped_refptr<ExportedObject> exported_object =
       new ExportedObject(this, object_path);
   exported_object_table_[object_path] = exported_object;
 
   return exported_object.get();
 }
 
+void Bus::UnregisterExportedObject(const ObjectPath& object_path) {
+  AssertOnOriginThread();
+
+  // Remove the registered object from the table first, to allow a new
+  // GetExportedObject() call to return a new object, rather than this one.
+  ExportedObjectTable::iterator iter = exported_object_table_.find(object_path);
+  if (iter == exported_object_table_.end())
+    return;
+
+  scoped_refptr<ExportedObject> exported_object = iter->second;
+  exported_object_table_.erase(iter);
+
+  // Post the task to perform the final unregistration to the D-Bus thread.
+  // Since the registration also happens on the D-Bus thread, and the message
+  // loop proxy is a SequencedTaskRunner, there is a guarantee that this will

[satorux1, 2012/03/13 20:15:33]

I was confused at first. might want to add something like

// loop proxy is a SequencedTaskRunner (i.e. MessageLoopProxy inherits from
SequencedTaskRunner)

[keybuk, 2012/03/13 20:25:01]

Done.

+  // happen before any future registration call.
+  PostTaskToDBusThread(FROM_HERE, base::Bind(
+      &Bus::UnregisterExportedObjectInternal,
+      this, exported_object));
+}
+
+void Bus::UnregisterExportedObjectInternal(
+    scoped_refptr<dbus::ExportedObject> exported_object) {
+  AssertOnDBusThread();
+
+  exported_object->Unregister();
+}
+
 bool Bus::Connect() {
   // dbus_bus_get_private() and dbus_bus_get() are blocking calls.
   AssertOnDBusThread();
 
   // Check if it's already initialized.
   if (connection_)
     return true;
 
   ScopedDBusError error;
   const DBusBusType dbus_bus_type = static_cast<DBusBusType>(bus_type_);
@@ skipping 526 matching lines @@
 }
 
 void Bus::OnDispatchStatusChangedThunk(DBusConnection* connection,
                                        DBusDispatchStatus status,
                                        void* data) {
   Bus* self = static_cast<Bus*>(data);
   return self->OnDispatchStatusChanged(connection, status);
 }
 
 }  // namespace dbus