Issue 9691017: Merge the fix for NSPR bug 689188.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9691017: Merge the fix for NSPR bug 689188. (Closed)

Created:
8 years, 9 months ago by wtc

Modified:
8 years, 9 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Merge the fix for NSPR bug 689188. Cast char to unsigned char before passing it to isalpha to prevent it from becoming a negative integer if char is a signed type. See https://bugzilla.mozilla.org/show_bug.cgi?id=689188. R=mark@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126338

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	base/third_party/nspr/prtime.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/9691017/1

8 years, 9 months ago (2012-03-13 03:00:31 UTC) #3

Change committed as 126338