Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9690006: Move Proxy Settings API from chrome/browser/extensions to chrome/browser/eextensions/api/proxy (Closed)

Created:
8 years, 9 months ago by battre
Modified:
8 years, 9 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, cbentzel+watch_chromium.org, darin-cc_chromium.org, mihaip+watch_chromium.org
Visibility:
Public.

Description

Move Proxy Settings API from chrome/browser/extensions to chrome/browser/eextensions/api/proxy BUG=101244 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -1692 lines) Patch
A + chrome/browser/extensions/api/proxy/proxy_api.h View 4 chunks +14 lines, -10 lines 0 comments Download
A + chrome/browser/extensions/api/proxy/proxy_api.cc View 3 chunks +16 lines, -12 lines 0 comments Download
A + chrome/browser/extensions/api/proxy/proxy_api_constants.h View 2 chunks +8 lines, -6 lines 0 comments Download
A + chrome/browser/extensions/api/proxy/proxy_api_constants.cc View 2 chunks +6 lines, -4 lines 0 comments Download
A + chrome/browser/extensions/api/proxy/proxy_api_helpers.h View 3 chunks +8 lines, -6 lines 0 comments Download
A + chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 4 chunks +9 lines, -6 lines 0 comments Download
A + chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc View 4 chunks +9 lines, -6 lines 0 comments Download
A + chrome/browser/extensions/api/proxy/proxy_apitest.cc View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_preference_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
D chrome/browser/extensions/extension_proxy_api.h View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/extensions/extension_proxy_api.cc View 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/browser/extensions/extension_proxy_api_constants.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/extensions/extension_proxy_api_constants.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/extensions/extension_proxy_api_helpers.h View 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/browser/extensions/extension_proxy_api_helpers.cc View 1 chunk +0 lines, -488 lines 0 comments Download
D chrome/browser/extensions/extension_proxy_api_helpers_unittest.cc View 1 chunk +0 lines, -362 lines 0 comments Download
D chrome/browser/extensions/extension_proxy_apitest.cc View 1 chunk +0 lines, -280 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
battre
Hi Matt, could you please review this? Thanks. Dominic
8 years, 9 months ago (2012-03-12 10:09:40 UTC) #1
Matt Perry
lgtm
8 years, 9 months ago (2012-03-12 18:28:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/9690006/1
8 years, 9 months ago (2012-03-12 18:30:44 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-12 21:18:03 UTC) #4 
Change committed as 126227

Powered by Google App Engine
This is Rietveld 408576698