Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 9690001: mac: Make content depend on mach_override in shared builds (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

mac: Make content depend on mach_override in shared builds mach_override is used by both content and chrome. Since it's small, it's easier to just statically link it into both targets. BUG=90078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M content/content.gyp View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
8 years, 9 months ago (2012-03-12 04:17:20 UTC) #1
Avi (use Gerrit)
lgtm
8 years, 9 months ago (2012-03-12 05:19:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9690001/1
8 years, 9 months ago (2012-03-12 05:31:48 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-12 06:51:01 UTC) #4
Change committed as 126103

Powered by Google App Engine
This is Rietveld 408576698