Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: net/spdy/spdy_protocol_spdy3_test.cc

Issue 9689078: SPDY - unforked spdy_framer and spdy_protocol tests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_protocol_spdy2_test.cc ('k') | net/spdy/spdy_protocol_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_protocol_spdy3_test.cc
===================================================================
--- net/spdy/spdy_protocol_spdy3_test.cc (revision 126690)
+++ net/spdy/spdy_protocol_spdy3_test.cc (working copy)
@@ -1,386 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "net/spdy/spdy_protocol.h"
-
-#include "base/memory/scoped_ptr.h"
-#include "net/spdy/spdy_bitmasks.h"
-#include "net/spdy/spdy_framer.h"
-#include "testing/platform_test.h"
-
-using spdy::CONTROL_FLAG_FIN;
-using spdy::CONTROL_FLAG_NONE;
-using spdy::FlagsAndLength;
-using spdy::GOAWAY;
-using spdy::HEADERS;
-using spdy::NOOP;
-using spdy::NUM_CONTROL_FRAME_TYPES;
-using spdy::PING;
-using spdy::RST_STREAM;
-using spdy::SETTINGS;
-using spdy::SYN_REPLY;
-using spdy::SYN_STREAM;
-using spdy::SettingsFlagsAndId;
-using spdy::SpdyControlFrame;
-using spdy::SpdyControlType;
-using spdy::SpdyDataFrame;
-using spdy::SpdyFrame;
-using spdy::SpdyFramer;
-using spdy::SpdyGoAwayControlFrame;
-using spdy::SpdyHeaderBlock;
-using spdy::SpdyHeadersControlFrame;
-using spdy::SpdyPingControlFrame;
-using spdy::SpdyRstStreamControlFrame;
-using spdy::SpdySettings;
-using spdy::SpdySettingsControlFrame;
-using spdy::SpdyStatusCodes;
-using spdy::SpdySynReplyControlFrame;
-using spdy::SpdySynStreamControlFrame;
-using spdy::SpdyWindowUpdateControlFrame;
-using spdy::WINDOW_UPDATE;
-using spdy::kLengthMask;
-using spdy::kStreamIdMask;
-
-namespace {
-
-// Default SPDY version for unit tests.
-const int SPDY_VERSION_FOR_TESTS = 3;
-
-// Test our protocol constants
-TEST(SpdyProtocolSpdy3Test, ProtocolConstants) {
- EXPECT_EQ(8u, SpdyFrame::kHeaderSize);
- EXPECT_EQ(8u, SpdyDataFrame::size());
- EXPECT_EQ(8u, SpdyControlFrame::kHeaderSize);
- EXPECT_EQ(18u, SpdySynStreamControlFrame::size());
- EXPECT_EQ(12u, SpdySynReplyControlFrame::size());
- EXPECT_EQ(16u, SpdyRstStreamControlFrame::size());
- EXPECT_EQ(12u, SpdySettingsControlFrame::size());
- EXPECT_EQ(12u, SpdyPingControlFrame::size());
- EXPECT_EQ(12u, SpdyGoAwayControlFrame::size());
- EXPECT_EQ(12u, SpdyHeadersControlFrame::size());
- EXPECT_EQ(16u, SpdyWindowUpdateControlFrame::size());
- EXPECT_EQ(4u, sizeof(FlagsAndLength));
- EXPECT_EQ(1, SYN_STREAM);
- EXPECT_EQ(2, SYN_REPLY);
- EXPECT_EQ(3, RST_STREAM);
- EXPECT_EQ(4, SETTINGS);
- EXPECT_EQ(5, NOOP);
- EXPECT_EQ(6, PING);
- EXPECT_EQ(7, GOAWAY);
- EXPECT_EQ(8, HEADERS);
- EXPECT_EQ(9, WINDOW_UPDATE);
-}
-
-// Test some of the protocol helper functions
-TEST(SpdyProtocolSpdy3Test, FrameStructs) {
- SpdyFrame frame(SpdyFrame::kHeaderSize);
- frame.set_length(12345);
- frame.set_flags(10);
- EXPECT_EQ(12345u, frame.length());
- EXPECT_EQ(10u, frame.flags());
- EXPECT_FALSE(frame.is_control_frame());
-
- frame.set_length(0);
- frame.set_flags(10);
- EXPECT_EQ(0u, frame.length());
- EXPECT_EQ(10u, frame.flags());
- EXPECT_FALSE(frame.is_control_frame());
-}
-
-TEST(SpdyProtocolSpdy3Test, DataFrameStructs) {
- SpdyDataFrame data_frame;
- data_frame.set_stream_id(12345);
- EXPECT_EQ(12345u, data_frame.stream_id());
-}
-
-TEST(SpdyProtocolSpdy3Test, ControlFrameStructs) {
- SpdyFramer framer(SPDY_VERSION_FOR_TESTS);
- SpdyHeaderBlock headers;
-
- scoped_ptr<SpdySynStreamControlFrame> syn_frame(
- framer.CreateSynStream(123, 456, 2, CONTROL_FLAG_FIN, false, &headers));
- EXPECT_EQ(framer.protocol_version(), syn_frame->version());
- EXPECT_TRUE(syn_frame->is_control_frame());
- EXPECT_EQ(SYN_STREAM, syn_frame->type());
- EXPECT_EQ(123u, syn_frame->stream_id());
- EXPECT_EQ(456u, syn_frame->associated_stream_id());
- EXPECT_EQ(2u, syn_frame->priority());
- EXPECT_EQ((SPDY_VERSION_FOR_TESTS < 3) ? 2 : 4,
- syn_frame->header_block_len());
- EXPECT_EQ(1u, syn_frame->flags());
- syn_frame->set_associated_stream_id(999u);
- EXPECT_EQ(123u, syn_frame->stream_id());
- EXPECT_EQ(999u, syn_frame->associated_stream_id());
-
- scoped_ptr<SpdySynReplyControlFrame> syn_reply(
- framer.CreateSynReply(123, CONTROL_FLAG_NONE, false, &headers));
- EXPECT_EQ(framer.protocol_version(), syn_reply->version());
- EXPECT_TRUE(syn_reply->is_control_frame());
- EXPECT_EQ(SYN_REPLY, syn_reply->type());
- EXPECT_EQ(123u, syn_reply->stream_id());
- EXPECT_EQ((SPDY_VERSION_FOR_TESTS < 3) ? 2 : 4,
- syn_reply->header_block_len());
- EXPECT_EQ(0, syn_reply->flags());
-
- scoped_ptr<SpdyRstStreamControlFrame> rst_frame(
- framer.CreateRstStream(123, spdy::PROTOCOL_ERROR));
- EXPECT_EQ(framer.protocol_version(), rst_frame->version());
- EXPECT_TRUE(rst_frame->is_control_frame());
- EXPECT_EQ(RST_STREAM, rst_frame->type());
- EXPECT_EQ(123u, rst_frame->stream_id());
- EXPECT_EQ(spdy::PROTOCOL_ERROR, rst_frame->status());
- rst_frame->set_status(spdy::INVALID_STREAM);
- EXPECT_EQ(spdy::INVALID_STREAM, rst_frame->status());
- EXPECT_EQ(0, rst_frame->flags());
-
- const uint32 kUniqueId = 1234567u;
- const uint32 kUniqueId2 = 31415926u;
- scoped_ptr<SpdyPingControlFrame> ping_frame(
- framer.CreatePingFrame(kUniqueId));
- EXPECT_EQ(framer.protocol_version(), ping_frame->version());
- EXPECT_TRUE(ping_frame->is_control_frame());
- EXPECT_EQ(PING, ping_frame->type());
- EXPECT_EQ(kUniqueId, ping_frame->unique_id());
- ping_frame->set_unique_id(kUniqueId2);
- EXPECT_EQ(kUniqueId2, ping_frame->unique_id());
-
- scoped_ptr<SpdyGoAwayControlFrame> goaway_frame(
- framer.CreateGoAway(123));
- EXPECT_EQ(framer.protocol_version(), goaway_frame->version());
- EXPECT_TRUE(goaway_frame->is_control_frame());
- EXPECT_EQ(GOAWAY, goaway_frame->type());
- EXPECT_EQ(123u, goaway_frame->last_accepted_stream_id());
-
- scoped_ptr<SpdyHeadersControlFrame> headers_frame(
- framer.CreateHeaders(123, CONTROL_FLAG_NONE, false, &headers));
- EXPECT_EQ(framer.protocol_version(), headers_frame->version());
- EXPECT_TRUE(headers_frame->is_control_frame());
- EXPECT_EQ(HEADERS, headers_frame->type());
- EXPECT_EQ(123u, headers_frame->stream_id());
- EXPECT_EQ((SPDY_VERSION_FOR_TESTS < 3) ? 2 : 4,
- headers_frame->header_block_len());
- EXPECT_EQ(0, headers_frame->flags());
-
- scoped_ptr<SpdyWindowUpdateControlFrame> window_update_frame(
- framer.CreateWindowUpdate(123, 456));
- EXPECT_EQ(framer.protocol_version(), window_update_frame->version());
- EXPECT_TRUE(window_update_frame->is_control_frame());
- EXPECT_EQ(WINDOW_UPDATE, window_update_frame->type());
- EXPECT_EQ(123u, window_update_frame->stream_id());
- EXPECT_EQ(456u, window_update_frame->delta_window_size());
-}
-
-TEST(SpdyProtocolSpdy3Test, TestDataFrame) {
- SpdyDataFrame frame;
-
- // Set the stream ID to various values.
- frame.set_stream_id(0);
- EXPECT_EQ(0u, frame.stream_id());
- EXPECT_FALSE(frame.is_control_frame());
- frame.set_stream_id(~0 & kStreamIdMask);
- EXPECT_EQ(~0 & kStreamIdMask, frame.stream_id());
- EXPECT_FALSE(frame.is_control_frame());
-
- // Set length to various values. Make sure that when you set_length(x),
- // length() == x. Also make sure the flags are unaltered.
- memset(frame.data(), '1', SpdyDataFrame::size());
- int8 flags = frame.flags();
- frame.set_length(0);
- EXPECT_EQ(0u, frame.length());
- EXPECT_EQ(flags, frame.flags());
- frame.set_length(kLengthMask);
- EXPECT_EQ(kLengthMask, frame.length());
- EXPECT_EQ(flags, frame.flags());
- frame.set_length(5u);
- EXPECT_EQ(5u, frame.length());
- EXPECT_EQ(flags, frame.flags());
-
- // Set flags to various values. Make sure that when you set_flags(x),
- // flags() == x. Also make sure the length is unaltered.
- memset(frame.data(), '1', SpdyDataFrame::size());
- uint32 length = frame.length();
- frame.set_flags(0u);
- EXPECT_EQ(0u, frame.flags());
- EXPECT_EQ(length, frame.length());
- int8 all_flags = ~0;
- frame.set_flags(all_flags);
- flags = frame.flags();
- EXPECT_EQ(all_flags, flags);
- EXPECT_EQ(length, frame.length());
- frame.set_flags(5u);
- EXPECT_EQ(5u, frame.flags());
- EXPECT_EQ(length, frame.length());
-}
-
-// Test various types of SETTINGS frames.
-TEST(SpdyProtocolSpdy3Test, TestSpdySettingsFrame) {
- SpdyFramer framer(SPDY_VERSION_FOR_TESTS);
-
- // Create a settings frame with no settings.
- SpdySettings settings;
- scoped_ptr<SpdySettingsControlFrame> settings_frame(
- framer.CreateSettings(settings));
- EXPECT_EQ(framer.protocol_version(), settings_frame->version());
- EXPECT_TRUE(settings_frame->is_control_frame());
- EXPECT_EQ(SETTINGS, settings_frame->type());
- EXPECT_EQ(0u, settings_frame->num_entries());
-
- // We'll add several different ID/Flag combinations and then verify
- // that they encode and decode properly.
- SettingsFlagsAndId ids[] = {
- SettingsFlagsAndId::FromWireFormat(SPDY_VERSION_FOR_TESTS, 0x00000000),
- SettingsFlagsAndId::FromWireFormat(SPDY_VERSION_FOR_TESTS, 0xffffffff),
- SettingsFlagsAndId::FromWireFormat(SPDY_VERSION_FOR_TESTS, 0xff000001),
- SettingsFlagsAndId::FromWireFormat(SPDY_VERSION_FOR_TESTS, 0xffffffff),
- SettingsFlagsAndId::FromWireFormat(SPDY_VERSION_FOR_TESTS, 0x01000002),
- SettingsFlagsAndId(3, 1)
- };
-
- for (size_t index = 0; index < arraysize(ids); ++index) {
- settings.insert(settings.end(), std::make_pair(ids[index], index));
- settings_frame.reset(framer.CreateSettings(settings));
- EXPECT_EQ(framer.protocol_version(), settings_frame->version());
- EXPECT_TRUE(settings_frame->is_control_frame());
- EXPECT_EQ(SETTINGS, settings_frame->type());
- EXPECT_EQ(index + 1, settings_frame->num_entries());
-
- SpdySettings parsed_settings;
- EXPECT_TRUE(framer.ParseSettings(settings_frame.get(), &parsed_settings));
- EXPECT_EQ(settings.size(), parsed_settings.size());
- SpdySettings::const_iterator it = parsed_settings.begin();
- int pos = 0;
- while (it != parsed_settings.end()) {
- SettingsFlagsAndId parsed = it->first;
- uint32 value = it->second;
- EXPECT_EQ(ids[pos].flags(), parsed.flags());
- EXPECT_EQ(ids[pos].id(), parsed.id());
- EXPECT_EQ(static_cast<uint32>(pos), value);
- ++it;
- ++pos;
- }
- }
-}
-
-TEST(SpdyProtocolSpdy3Test, HasHeaderBlock) {
- SpdyControlFrame frame(SpdyControlFrame::kHeaderSize);
- for (SpdyControlType type = SYN_STREAM;
- type < NUM_CONTROL_FRAME_TYPES;
- type = static_cast<SpdyControlType>(type + 1)) {
- frame.set_type(type);
- if (type == SYN_STREAM || type == SYN_REPLY || type == HEADERS) {
- EXPECT_TRUE(frame.has_header_block());
- } else {
- EXPECT_FALSE(frame.has_header_block());
- }
- }
-}
-
-// Make sure that overflows both die in debug mode, and do not cause problems
-// in opt mode. Note: The EXPECT_DEBUG_DEATH call does not work on Win32 yet,
-// so we comment it out.
-TEST(SpdyProtocolDeathSpdy3Test, TestDataFrame) {
- SpdyDataFrame frame;
-
- frame.set_stream_id(0);
- // TODO(mbelshe): implement EXPECT_DEBUG_DEATH on windows.
-#if !defined(WIN32) && defined(GTEST_HAS_DEATH_TEST)
-#if !defined(DCHECK_ALWAYS_ON)
- EXPECT_DEBUG_DEATH(frame.set_stream_id(~0), "");
-#else
- EXPECT_DEATH(frame.set_stream_id(~0), "");
-#endif
-#endif
- EXPECT_FALSE(frame.is_control_frame());
-
- frame.set_flags(0);
-#if !defined(WIN32) && defined(GTEST_HAS_DEATH_TEST)
-#if !defined(DCHECK_ALWAYS_ON)
- EXPECT_DEBUG_DEATH(frame.set_length(~0), "");
-#else
- EXPECT_DEATH(frame.set_length(~0), "");
-#endif
-#endif
- EXPECT_EQ(0, frame.flags());
-}
-
-TEST(SpdyProtocolDeathSpdy3Test, TestSpdyControlFrameStreamId) {
- SpdyControlFrame frame_store(SpdySynStreamControlFrame::size());
- memset(frame_store.data(), '1', SpdyControlFrame::kHeaderSize);
- SpdySynStreamControlFrame* frame =
- reinterpret_cast<SpdySynStreamControlFrame*>(&frame_store);
-
- // Set the stream ID to various values.
- frame->set_stream_id(0);
- EXPECT_EQ(0u, frame->stream_id());
- EXPECT_FALSE(frame->is_control_frame());
- frame->set_stream_id(kStreamIdMask);
- EXPECT_EQ(kStreamIdMask, frame->stream_id());
- EXPECT_FALSE(frame->is_control_frame());
-}
-
-TEST(SpdyProtocolDeathSpdy3Test, TestSpdyControlFrameVersion) {
- const unsigned int kVersionMask = 0x7fff;
- SpdyControlFrame frame(SpdySynStreamControlFrame::size());
- memset(frame.data(), '1', SpdyControlFrame::kHeaderSize);
-
- // Set the version to various values, and make sure it does not affect the
- // type.
- frame.set_type(SYN_STREAM);
- frame.set_version(0);
- EXPECT_EQ(0, frame.version());
- EXPECT_TRUE(frame.is_control_frame());
- EXPECT_EQ(SYN_STREAM, frame.type());
-
- SpdySynStreamControlFrame* syn_stream =
- reinterpret_cast<SpdySynStreamControlFrame*>(&frame);
- syn_stream->set_stream_id(~0 & kVersionMask);
- EXPECT_EQ(~0 & kVersionMask, syn_stream->stream_id());
- EXPECT_TRUE(frame.is_control_frame());
- EXPECT_EQ(SYN_STREAM, frame.type());
-}
-
-TEST(SpdyProtocolDeathSpdy3Test, TestSpdyControlFrameType) {
- SpdyControlFrame frame(SpdyControlFrame::kHeaderSize);
- memset(frame.data(), 255, SpdyControlFrame::kHeaderSize);
-
- // type() should be out of bounds.
- EXPECT_FALSE(frame.AppearsToBeAValidControlFrame());
-
- frame.set_version(SPDY_VERSION_FOR_TESTS);
- uint16 version = frame.version();
-
- for (int i = SYN_STREAM; i <= spdy::WINDOW_UPDATE; ++i) {
- frame.set_type(static_cast<SpdyControlType>(i));
- EXPECT_EQ(i, static_cast<int>(frame.type()));
- if (i == spdy::NOOP) {
- // NOOP frames aren't 'valid'.
- EXPECT_FALSE(frame.AppearsToBeAValidControlFrame());
- } else {
- EXPECT_TRUE(frame.AppearsToBeAValidControlFrame());
- }
- // Make sure setting type does not alter the version block.
- EXPECT_EQ(version, frame.version());
- EXPECT_TRUE(frame.is_control_frame());
- }
-}
-
-TEST(SpdyProtocolDeathSpdy3Test, TestRstStreamStatusBounds) {
- SpdyFramer framer(SPDY_VERSION_FOR_TESTS);
- scoped_ptr<SpdyRstStreamControlFrame> rst_frame;
-
- rst_frame.reset(framer.CreateRstStream(123, spdy::PROTOCOL_ERROR));
- EXPECT_EQ(spdy::PROTOCOL_ERROR, rst_frame->status());
-
- rst_frame->set_status(spdy::INVALID);
- EXPECT_EQ(spdy::INVALID, rst_frame->status());
-
- rst_frame->set_status(
- static_cast<spdy::SpdyStatusCodes>(spdy::INVALID - 1));
- EXPECT_EQ(spdy::INVALID, rst_frame->status());
-
- rst_frame->set_status(spdy::NUM_STATUS_CODES);
- EXPECT_EQ(spdy::INVALID, rst_frame->status());
-}
-
-} // namespace
« no previous file with comments | « net/spdy/spdy_protocol_spdy2_test.cc ('k') | net/spdy/spdy_protocol_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698