Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 9689076: Add missing ppp_graphics_3d.idl (Closed)

Created:
8 years, 9 months ago by noelallen1
Modified:
8 years, 9 months ago
Reviewers:
piman, brettw, alokp
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org, ilja
Visibility:
Public.

Description

Add missing ppp_graphics_3d.idl The ppb version of the interface was added, this CL adds the missing ppp portion. See: http://codereview.chromium.org/9340003 Alok for verification, Brett for OWNER. R=alokp@chromium.org,brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127281

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -4 lines) Patch
A ppapi/api/ppp_graphics_3d.idl View 1 chunk +25 lines, -0 lines 0 comments Download
M ppapi/c/ppp_graphics_3d.h View 1 chunk +28 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_graphics_3d_proxy.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
noelallen1
8 years, 9 months ago (2012-03-13 21:01:34 UTC) #1
brettw
lgtm
8 years, 9 months ago (2012-03-13 21:56:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/9689076/4003
8 years, 9 months ago (2012-03-15 00:38:02 UTC) #3
commit-bot: I haz the power
Try job failure for 9689076-4003 (retry) (previous was lost) on win for step "compile" (clobber ...
8 years, 9 months ago (2012-03-15 03:47:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/9689076/4003
8 years, 9 months ago (2012-03-15 16:54:37 UTC) #5
commit-bot: I haz the power
Try job failure for 9689076-4003 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-15 19:58:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/9689076/4003
8 years, 9 months ago (2012-03-16 17:06:04 UTC) #7
commit-bot: I haz the power
Change committed as 127281
8 years, 9 months ago (2012-03-16 23:00:12 UTC) #8
piman
NOTE: This CL changed the interface name "PPP_Graphics3D;1.0" vs ""PPP_Graphics_3D;1.0" (note the underscore), breaking Flash's ...
8 years, 9 months ago (2012-03-21 22:22:38 UTC) #9
viettrungluu
On 2012/03/21 22:22:38, piman wrote: > NOTE: This CL changed the interface name "PPP_Graphics3D;1.0" vs ...
8 years, 9 months ago (2012-03-21 22:38:14 UTC) #10
viettrungluu
8 years, 9 months ago (2012-03-22 02:58:20 UTC) #11
On 2012/03/21 22:38:14, viettrungluu wrote:
> On 2012/03/21 22:22:38, piman wrote:
> > NOTE: This CL changed the interface name "PPP_Graphics3D;1.0" vs
> > ""PPP_Graphics_3D;1.0" (note the underscore), breaking Flash's lost context
> > recovery.
> 
> Please revert this ASAP. It changes a stable interface.
> 
> It can be re-landed if and only if it adds suitable backwards compatibility.

To follow up on this, Noel fixed this in http://codereview.chromium.org/9811027/
(landed r128140).

Powered by Google App Engine
This is Rietveld 408576698