Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9689058: Disable chrome://downloads ui for Android. (Closed)

Created:
8 years, 9 months ago by Yaron
Modified:
8 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Disable chrome://downloads ui for Android. On Android we use the native download manager (and this is causing link errors). BUG=117407 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126881

Patch Set 1 #

Total comments: 3

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yaron
8 years, 9 months ago (2012-03-13 11:39:25 UTC) #1
Evan Stade
lgtm https://chromiumcodereview.appspot.com/9689058/diff/1/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right): https://chromiumcodereview.appspot.com/9689058/diff/1/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc#newcode232 chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:232: // Android uses the native download manager . ...
8 years, 9 months ago (2012-03-14 21:13:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9689058/5001
8 years, 9 months ago (2012-03-14 23:29:16 UTC) #3
commit-bot: I haz the power
Try job failure for 9689058-5001 on linux_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=9044 Step "update" is always ...
8 years, 9 months ago (2012-03-14 23:38:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9689058/5001
8 years, 9 months ago (2012-03-14 23:56:15 UTC) #5
commit-bot: I haz the power
Try job failure for 9689058-5001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-15 03:17:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9689058/5001
8 years, 9 months ago (2012-03-15 08:34:24 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 10:34:21 UTC) #8 
Change committed as 126881

Powered by Google App Engine
This is Rietveld 408576698