Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 9689034: [Coverity] Fixed wrong use of HANDLE_EINTR (Closed)

Created:
8 years, 9 months ago by groby-ooo-7-16
Modified:
8 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[Coverity] Fixed wrong use of HANDLE_EINTR The macro usage as-is would evaluate the whole content of the if-statement for HANDLE_EINTR, instead of just the write(...) part - as a result, EINTR will not be handled CID=103483 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/zygote_main_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
groby-ooo-7-16
Please review
8 years, 9 months ago (2012-03-12 23:23:34 UTC) #1
jam
8 years, 9 months ago (2012-03-13 17:11:27 UTC) #2
jam
lgtm
8 years, 9 months ago (2012-03-13 17:11:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9689034/1
8 years, 9 months ago (2012-03-13 17:31:48 UTC) #4
commit-bot: I haz the power
Try job failure for 9689034-1 (retry) on win_rel for steps "ui_tests, browser_tests". It's a second ...
8 years, 9 months ago (2012-03-13 20:29:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9689034/1
8 years, 9 months ago (2012-03-13 21:00:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9689034/1
8 years, 9 months ago (2012-03-13 21:23:58 UTC) #7
commit-bot: I haz the power
Try job failure for 9689034-1 (retry) on win_rel for steps "browser_tests, installer_util_unittests". It's a second ...
8 years, 9 months ago (2012-03-14 01:14:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9689034/1
8 years, 9 months ago (2012-03-14 02:30:13 UTC) #9
commit-bot: I haz the power
Try job failure for 9689034-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-14 04:43:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9689034/1
8 years, 9 months ago (2012-03-14 15:01:57 UTC) #11
commit-bot: I haz the power
Try job failure for 9689034-1 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=8603 Step "update" is always ...
8 years, 9 months ago (2012-03-14 15:04:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9689034/1
8 years, 9 months ago (2012-03-14 17:24:26 UTC) #13
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 19:58:13 UTC) #14
Change committed as 126708

Powered by Google App Engine
This is Rietveld 408576698