Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: webkit/dom_storage/dom_storage_task_runner.cc

Issue 9689033: Derive DomStorageTaskRunner from base::TaskRunner now that it exists. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/dom_storage/dom_storage_task_runner.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/dom_storage/dom_storage_task_runner.h" 5 #include "webkit/dom_storage/dom_storage_task_runner.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/message_loop_proxy.h" 9 #include "base/message_loop_proxy.h"
10 #include "base/tracked_objects.h" 10 #include "base/tracked_objects.h"
11 11
12 namespace dom_storage { 12 namespace dom_storage {
13 13
14 // DomStorageTaskRunner 14 // DomStorageTaskRunner
15 15
16 DomStorageTaskRunner::DomStorageTaskRunner( 16 DomStorageTaskRunner::DomStorageTaskRunner(
17 base::MessageLoopProxy* message_loop) 17 base::MessageLoopProxy* message_loop)
18 : message_loop_(message_loop) { 18 : message_loop_(message_loop) {
19 } 19 }
20 20
21 DomStorageTaskRunner::~DomStorageTaskRunner() { 21 DomStorageTaskRunner::~DomStorageTaskRunner() {
22 } 22 }
23 23
24 bool DomStorageTaskRunner::PostTask(
25 const tracked_objects::Location& from_here,
26 const base::Closure& task) {
27 return message_loop_->PostTask(from_here, task);
28 }
29
30 bool DomStorageTaskRunner::PostDelayedTask( 24 bool DomStorageTaskRunner::PostDelayedTask(
31 const tracked_objects::Location& from_here, 25 const tracked_objects::Location& from_here,
32 const base::Closure& task, 26 const base::Closure& task,
33 base::TimeDelta delay) { 27 base::TimeDelta delay) {
34 return message_loop_->PostDelayedTask(from_here, task, delay); 28 return message_loop_->PostDelayedTask(from_here, task, delay);
35 } 29 }
36 30
31 bool DomStorageTaskRunner::PostDelayedTask(
32 const tracked_objects::Location& from_here,
33 const base::Closure& task,
34 int64 delay_ms) {
35 return PostDelayedTask(
36 from_here, task, base::TimeDelta::FromMilliseconds(delay_ms));
37 }
38
39 bool DomStorageTaskRunner::RunsTasksOnCurrentThread() const {
40 return true;
41 }
42
37 // DomStorageWorkerPoolTaskRunner 43 // DomStorageWorkerPoolTaskRunner
38 44
39 DomStorageWorkerPoolTaskRunner::DomStorageWorkerPoolTaskRunner( 45 DomStorageWorkerPoolTaskRunner::DomStorageWorkerPoolTaskRunner(
40 base::SequencedWorkerPool* sequenced_worker_pool, 46 base::SequencedWorkerPool* sequenced_worker_pool,
47 base::SequencedWorkerPool::SequenceToken sequence_token,
41 base::MessageLoopProxy* delayed_task_loop) 48 base::MessageLoopProxy* delayed_task_loop)
42 : DomStorageTaskRunner(delayed_task_loop), 49 : DomStorageTaskRunner(delayed_task_loop),
43 sequenced_worker_pool_(sequenced_worker_pool), 50 sequenced_worker_pool_(sequenced_worker_pool),
44 sequence_token_( 51 sequence_token_(sequence_token) {
45 sequenced_worker_pool->GetNamedSequenceToken("dom_storage_token")) {
46 } 52 }
47 53
48 DomStorageWorkerPoolTaskRunner::~DomStorageWorkerPoolTaskRunner() { 54 DomStorageWorkerPoolTaskRunner::~DomStorageWorkerPoolTaskRunner() {
49 } 55 }
50 56
51 bool DomStorageWorkerPoolTaskRunner::PostTask(
52 const tracked_objects::Location& from_here,
53 const base::Closure& task) {
54 // We can skip on shutdown as the destructor of DomStorageArea will ensure
55 // that any remaining data is committed to disk.
56 return sequenced_worker_pool_->PostSequencedWorkerTaskWithShutdownBehavior(
57 sequence_token_, from_here, task,
58 base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
59 }
60
61 bool DomStorageWorkerPoolTaskRunner::PostDelayedTask( 57 bool DomStorageWorkerPoolTaskRunner::PostDelayedTask(
62 const tracked_objects::Location& from_here, 58 const tracked_objects::Location& from_here,
63 const base::Closure& task, 59 const base::Closure& task,
64 base::TimeDelta delay) { 60 base::TimeDelta delay) {
61 // Note base::TaskRunner implements PostTask in terms of PostDelayedTask
62 // with a delay of zero, we detect that usage and avoid the unecessary
63 // trip thru the message_loop.
64 if (delay == base::TimeDelta()) {
65 // We can skip on shutdown as the destructor of DomStorageArea will ensure
66 // that any remaining data is committed to disk.
67 return sequenced_worker_pool_->PostSequencedWorkerTaskWithShutdownBehavior(
68 sequence_token_, from_here, task,
69 base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
70 }
65 // Post a task to call this->PostTask() after the delay. 71 // Post a task to call this->PostTask() after the delay.
66 return message_loop_->PostDelayedTask( 72 return message_loop_->PostDelayedTask(
67 FROM_HERE, 73 FROM_HERE,
68 base::Bind(base::IgnoreResult(&DomStorageWorkerPoolTaskRunner::PostTask), 74 base::Bind(base::IgnoreResult(&DomStorageWorkerPoolTaskRunner::PostTask),
69 this, from_here, task), 75 this, from_here, task),
70 delay); 76 delay);
71 } 77 }
72 78
73 // MockDomStorageTaskRunner 79 // MockDomStorageTaskRunner
74 80
75 MockDomStorageTaskRunner::MockDomStorageTaskRunner( 81 MockDomStorageTaskRunner::MockDomStorageTaskRunner(
76 base::MessageLoopProxy* message_loop) 82 base::MessageLoopProxy* message_loop)
77 : DomStorageTaskRunner(message_loop) { 83 : DomStorageTaskRunner(message_loop) {
78 } 84 }
79 85
80 bool MockDomStorageTaskRunner::PostDelayedTask( 86 bool MockDomStorageTaskRunner::PostDelayedTask(
81 const tracked_objects::Location& from_here, 87 const tracked_objects::Location& from_here,
82 const base::Closure& task, 88 const base::Closure& task,
83 base::TimeDelta delay) { 89 base::TimeDelta delay) {
84 // Don't wait in unit tests. 90 // Squash all delays to zero in our mock.
85 return PostTask(from_here, task); 91 return DomStorageTaskRunner::PostDelayedTask(
92 from_here, task, base::TimeDelta());
86 } 93 }
87 94
88 } // namespace dom_storage 95 } // namespace dom_storage
OLDNEW
« no previous file with comments | « webkit/dom_storage/dom_storage_task_runner.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698