Issue 9689028: Move work signal count tracking from SequencedWorkerPool to the test file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9689028: Move work signal count tracking from SequencedWorkerPool to the test file (Closed)

Created:
8 years, 9 months ago by akalin

Modified:
8 years, 9 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move work signal count tracking from SequencedWorkerPool to the test file Add OnHasWork() method to TestingObserver. Make TestingObserver a constructor parameter, so it can be read outside the lock. BUG=117469 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126780

Patch Set 1 #

Patch Set 2 : Diff to correct branch #

Patch Set 3 : Sync to head #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -54 lines)			Patch
M	base/threading/sequenced_worker_pool.h	View	1	4 chunks	+8 lines, -8 lines	0 comments	Download
M	base/threading/sequenced_worker_pool.cc	View	1	15 chunks	+26 lines, -40 lines	0 comments	Download
M	base/threading/sequenced_worker_pool_unittest.cc	View	1	5 chunks	+24 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

akalin

On 2012/03/12 21:07:57, akalin wrote: > +jar for review ping!

8 years, 9 months ago (2012-03-14 18:40:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9689028/9004

8 years, 9 months ago (2012-03-14 19:30:45 UTC) #4

Change committed as 126780

Expand Messages | Collapse Messages