Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 9689015: Remove unused AudioBuffersState member. (Closed)

Created:
8 years, 9 months ago by enal
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M content/common/media/audio_messages.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_buffers_state.h View 1 2 2 chunks +5 lines, -11 lines 0 comments Download
D media/audio/audio_buffers_state.cc View 1 2 1 chunk +2 lines, -8 lines 0 comments Download
M media/audio/linux/alsa_input.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
enal1
Victoria, can you please review the minor cleanup?
8 years, 9 months ago (2012-03-12 18:03:04 UTC) #1
vrk (LEFT CHROMIUM)
Removing the timestamp looks good, but I think audio_buffers_state.cc needs to stay. https://chromiumcodereview.appspot.com/9689015/diff/1/media/audio/audio_buffers_state.h File media/audio/audio_buffers_state.h ...
8 years, 9 months ago (2012-03-12 18:45:01 UTC) #2
enal1
Moved constructors into (undeleted) .cc file...
8 years, 9 months ago (2012-03-12 20:51:24 UTC) #3
vrk (LEFT CHROMIUM)
LGTM
8 years, 9 months ago (2012-03-12 20:55:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/9689015/6001
8 years, 9 months ago (2012-03-12 21:05:37 UTC) #5
commit-bot: I haz the power
Try job failure for 9689015-6001 (retry) on linux_rel for step "check_deps". It's a second try, ...
8 years, 9 months ago (2012-03-12 22:07:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/9689015/6001
8 years, 9 months ago (2012-03-13 14:58:59 UTC) #7
commit-bot: I haz the power
Try job failure for 9689015-6001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-13 17:34:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/9689015/6001
8 years, 9 months ago (2012-03-13 18:30:21 UTC) #9
commit-bot: I haz the power
Change committed as 126474
8 years, 9 months ago (2012-03-13 21:20:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/9689015/12001
8 years, 9 months ago (2012-03-14 15:49:11 UTC) #11
commit-bot: I haz the power
Try job failure for 9689015-12001 (retry) on linux_rel for step "remoting_unittests". It's a second try, ...
8 years, 9 months ago (2012-03-14 16:37:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/9689015/12001
8 years, 9 months ago (2012-03-14 19:02:00 UTC) #13
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 00:12:49 UTC) #14
Change committed as 126795

Powered by Google App Engine
This is Rietveld 408576698