Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: src/codegen-ia32.cc

Issue 9689: Reporting -1 as the size of an ILLEGAL reference which actually has... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/codegen-ia32.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen-ia32.cc
===================================================================
--- src/codegen-ia32.cc (revision 706)
+++ src/codegen-ia32.cc (working copy)
@@ -607,12 +607,10 @@
// Pop a reference from the stack while preserving TOS.
Comment cmnt(masm_, "[ UnloadReference");
int size = ref->size();
- if (size <= 0) {
- // Do nothing. No popping is necessary.
- } else if (size == 1) {
+ if (size == 1) {
frame_->Pop(eax);
__ mov(frame_->Top(), eax);
- } else {
+ } else if (size > 1) {
frame_->Pop(eax);
frame_->Drop(size);
frame_->Push(eax);
« no previous file with comments | « src/codegen-ia32.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698