src/codegen-arm.cc - Issue 9689: Reporting -1 as the size of an ILLEGAL reference which actually has...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codegen-arm.cc

Issue 9689: Reporting -1 as the size of an ILLEGAL reference which actually has... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 12 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/codegen-arm.cc

===================================================================

--- src/codegen-arm.cc (revision 706)

+++ src/codegen-arm.cc (working copy)

@@ -569,9 +569,7 @@

// Pop a reference from the stack while preserving TOS.

Comment cmnt(masm_, "[ UnloadReference");

int size = ref->size();

- if (size <= 0) {

- // Do nothing. No popping is necessary.

- } else {

+ if (size > 0) {

frame_->Pop(r0);

frame_->Drop(size);

frame_->Push(r0);

« no previous file with comments | « src/codegen-arm.h ('k') | src/codegen-ia32.h » ('j') | no next file with comments »