Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: src/codegen-arm.cc

Issue 9689: Reporting -1 as the size of an ILLEGAL reference which actually has... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/codegen-arm.h ('k') | src/codegen-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 551 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 Load(e); 562 Load(e);
563 __ CallRuntime(Runtime::kThrowReferenceError, 1); 563 __ CallRuntime(Runtime::kThrowReferenceError, 1);
564 } 564 }
565 } 565 }
566 566
567 567
568 void CodeGenerator::UnloadReference(Reference* ref) { 568 void CodeGenerator::UnloadReference(Reference* ref) {
569 // Pop a reference from the stack while preserving TOS. 569 // Pop a reference from the stack while preserving TOS.
570 Comment cmnt(masm_, "[ UnloadReference"); 570 Comment cmnt(masm_, "[ UnloadReference");
571 int size = ref->size(); 571 int size = ref->size();
572 if (size <= 0) { 572 if (size > 0) {
573 // Do nothing. No popping is necessary.
574 } else {
575 frame_->Pop(r0); 573 frame_->Pop(r0);
576 frame_->Drop(size); 574 frame_->Drop(size);
577 frame_->Push(r0); 575 frame_->Push(r0);
578 } 576 }
579 } 577 }
580 578
581 579
582 // ECMA-262, section 9.2, page 30: ToBoolean(). Convert the given 580 // ECMA-262, section 9.2, page 30: ToBoolean(). Convert the given
583 // register to a boolean in the condition code register. The code 581 // register to a boolean in the condition code register. The code
584 // may jump to 'false_target' in case the register converts to 'false'. 582 // may jump to 'false_target' in case the register converts to 'false'.
(...skipping 3692 matching lines...) Expand 10 before | Expand all | Expand 10 after
4277 // Slow-case: Non-function called. 4275 // Slow-case: Non-function called.
4278 __ bind(&slow); 4276 __ bind(&slow);
4279 __ mov(r0, Operand(argc_)); // Setup the number of arguments. 4277 __ mov(r0, Operand(argc_)); // Setup the number of arguments.
4280 __ InvokeBuiltin(Builtins::CALL_NON_FUNCTION, JUMP_JS); 4278 __ InvokeBuiltin(Builtins::CALL_NON_FUNCTION, JUMP_JS);
4281 } 4279 }
4282 4280
4283 4281
4284 #undef __ 4282 #undef __
4285 4283
4286 } } // namespace v8::internal 4284 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/codegen-arm.h ('k') | src/codegen-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698