Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 9688021: Avoid using Pickle::WriteSize(), which writes an architecture-dependent amount (Closed)

Created:
8 years, 9 months ago by Mike Mammarella
Modified:
8 years, 9 months ago
Reviewers:
dcheng
CC:
chromium-reviews, jar (doing other things)
Visibility:
Public.

Description

Avoid using Pickle::WriteSize(), which writes an architecture-dependent amount of data, in clipboard pickles. (The goal is to remove that method entirely. Uses that never persist or send pickles over the network are [probably] safe, but having the method around is waiting for accidental misuses.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126242

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M ui/base/clipboard/custom_data_helper.cc View 1 2 4 chunks +11 lines, -11 lines 0 comments Download
M ui/base/clipboard/custom_data_helper_unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike Mammarella
8 years, 9 months ago (2012-03-12 17:40:11 UTC) #1
dcheng
lgtm
8 years, 9 months ago (2012-03-12 18:22:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdm@chromium.org/9688021/2001
8 years, 9 months ago (2012-03-12 18:26:00 UTC) #3
commit-bot: I haz the power
Try job failure for 9688021-2001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-12 18:42:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdm@chromium.org/9688021/6004
8 years, 9 months ago (2012-03-12 20:13:31 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-12 21:42:54 UTC) #6
Change committed as 126242

Powered by Google App Engine
This is Rietveld 408576698