Issue 9688002: [protector] Added SessionStartupChange for representing changes in SessionStartupPref.

Issue 9688002: [protector] Added SessionStartupChange for representing changes in SessionStartupPref. (Closed)

Created:
8 years, 9 months ago by Ivan Korotkov

Modified:
8 years, 9 months ago

Reviewers:
whywhat

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[protector] Added SessionStartupChange for representing changes in SessionStartupPref. BUG=114288 TEST=SessionStartupChangeTest.*; no user-visible changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126257

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+360 lines, -7 lines)			Patch
M	chrome/app/generated_resources.grd	View		2 chunks	+28 lines, -3 lines	0 comments	Download
M	chrome/browser/prefs/session_startup_pref.h	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/protector/base_setting_change.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/protector/histograms.h	View		1 chunk	+13 lines, -3 lines	0 comments	Download
M	chrome/browser/protector/histograms.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/browser/protector/session_startup_change.cc	View	1	1 chunk	+166 lines, -0 lines	0 comments	Download
A	chrome/browser/protector/session_startup_change_unittest.cc	View		1 chunk	+131 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

whywhat

lgtm http://codereview.chromium.org/9688002/diff/1/chrome/browser/prefs/session_startup_pref.h File chrome/browser/prefs/session_startup_pref.h (right): http://codereview.chromium.org/9688002/diff/1/chrome/browser/prefs/session_startup_pref.h#newcode34 chrome/browser/prefs/session_startup_pref.h:34: MAX = URLS Did you mean LAST? :) ...

8 years, 9 months ago (2012-03-11 23:09:33 UTC) #2

Ivan Korotkov

http://codereview.chromium.org/9688002/diff/1/chrome/browser/prefs/session_startup_pref.h File chrome/browser/prefs/session_startup_pref.h (right): http://codereview.chromium.org/9688002/diff/1/chrome/browser/prefs/session_startup_pref.h#newcode34 chrome/browser/prefs/session_startup_pref.h:34: MAX = URLS On 2012/03/11 23:09:33, whywhat wrote: > ...

8 years, 9 months ago (2012-03-12 11:20:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/9688002/3002

8 years, 9 months ago (2012-03-12 14:05:45 UTC) #4

commit-bot: I haz the power

Try job failure for 9688002-3002 (retry) (retry) on win_rel for step "browser_tests" (clobber build). It's ...

8 years, 9 months ago (2012-03-12 17:09:42 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/9688002/3002

8 years, 9 months ago (2012-03-12 20:00:11 UTC) #6

Change committed as 126257

Expand Messages | Collapse Messages