Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 9682003: Check for specific PPB versions in C++ wrappers. (Closed)

Created:
8 years, 9 months ago by Wez
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Check for specific PPB versions in pp::Fullscreen, pp::Audio and pp::Graphics3D implementations. BUG=107398 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128047

Patch Set 1 #

Patch Set 2 : Actually check for interface v1.0. :) #

Patch Set 3 : Update PPB_Graphics3D #

Patch Set 4 : Update pp::Fullscreen in this CL, too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M ppapi/cpp/audio.cc View 1 2 chunks +8 lines, -9 lines 0 comments Download
M ppapi/cpp/fullscreen.cc View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M ppapi/cpp/graphics_3d.cc View 1 2 4 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Wez
PTAL
8 years, 9 months ago (2012-03-16 04:30:48 UTC) #1
nfullagar
might as well do fullscreen, graphics_2d and image_data as part of the same CL?
8 years, 9 months ago (2012-03-16 17:44:55 UTC) #2
Wez
On 2012/03/16 17:44:55, nfullagar wrote: > might as well do fullscreen, graphics_2d and image_data as ...
8 years, 9 months ago (2012-03-16 17:47:45 UTC) #3
Wez
On 2012/03/16 17:44:55, nfullagar wrote: > might as well do fullscreen, graphics_2d and image_data as ...
8 years, 9 months ago (2012-03-21 17:09:25 UTC) #4
nfullagar
lgtm
8 years, 9 months ago (2012-03-21 17:30:21 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-21 17:34:24 UTC) #6
Wez
dmichael: Do you have super-powers?
8 years, 9 months ago (2012-03-21 18:02:45 UTC) #7
dmichael (off chromium)
lgtm
8 years, 9 months ago (2012-03-21 18:05:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9682003/8001
8 years, 9 months ago (2012-03-21 18:11:32 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-21 20:46:46 UTC) #10
Change committed as 128047

Powered by Google App Engine
This is Rietveld 408576698