Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: webkit/plugins/ppapi/ppb_network_monitor_private_impl.cc

Issue 9677060: Out-of-process implementation of the PPB_NetworkMonitor_Private interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: - Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/thunk/ppb_network_list_private_api.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppb_network_monitor_private_impl.cc
diff --git a/webkit/plugins/ppapi/ppb_network_monitor_private_impl.cc b/webkit/plugins/ppapi/ppb_network_monitor_private_impl.cc
index 1dc261420ff4df947981b6c9f1a82af911a19d82..813e98f49908c344638ec886cd28221405578cea 100644
--- a/webkit/plugins/ppapi/ppb_network_monitor_private_impl.cc
+++ b/webkit/plugins/ppapi/ppb_network_monitor_private_impl.cc
@@ -6,6 +6,8 @@
#include "base/bind.h"
#include "ppapi/shared_impl/ppb_network_list_private_shared.h"
+#include "ppapi/shared_impl/private/net_address_private_impl.h"
+#include "net/base/ip_endpoint.h"
#include "net/base/net_util.h"
#include "webkit/plugins/ppapi/resource_helper.h"
@@ -56,18 +58,16 @@ bool PPB_NetworkMonitor_Private_Impl::Start() {
void PPB_NetworkMonitor_Private_Impl::OnNetworkListChanged(
const net::NetworkInterfaceList& list) {
- scoped_ptr< ::ppapi::PPB_NetworkList_Private_Shared::NetworkList> list_copy(
- new ::ppapi::PPB_NetworkList_Private_Shared::NetworkList(list.size()));
+ ::ppapi::NetworkList list_copy(list.size());
for (size_t i = 0; i < list.size(); ++i) {
- ::ppapi::PPB_NetworkList_Private_Shared::NetworkInfo& network =
- list_copy->at(i);
+ ::ppapi::NetworkInfo& network = list_copy.at(i);
network.name = list[i].name;
- network.addresses.resize(1);
- CHECK_LE(list[i].address.size(), sizeof(network.addresses[0].data));
- network.addresses[0].size = list[i].address.size();
- memcpy(network.addresses[0].data, &(list[i].address.front()),
- list[i].address.size());
+ network.addresses.resize(
+ 1, ::ppapi::NetAddressPrivateImpl::kInvalidNetAddress);
+ bool result = ::ppapi::NetAddressPrivateImpl::IPEndPointToNetAddress(
+ net::IPEndPoint(list[i].address, 0), &(network.addresses[0]));
+ DCHECK(result);
// TODO(sergeyu): Currently net::NetworkInterfaceList provides
// only name and one IP address. Add all other fields and copy
@@ -77,9 +77,11 @@ void PPB_NetworkMonitor_Private_Impl::OnNetworkListChanged(
network.display_name = list[i].name;
network.mtu = 0;
}
+ scoped_refptr< ::ppapi::NetworkListStorage> list_storage(
+ new ::ppapi::NetworkListStorage(list_copy));
PP_Resource list_resource =
::ppapi::PPB_NetworkList_Private_Shared::Create(
- ::ppapi::OBJECT_IS_IMPL, pp_instance(), list_copy.Pass());
+ ::ppapi::OBJECT_IS_IMPL, pp_instance(), list_storage);
callback_(user_data_, list_resource);
}
« no previous file with comments | « ppapi/thunk/ppb_network_list_private_api.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698